Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formulae: remove duplicate aliases/renames #162194

Merged
merged 28 commits into from
Feb 9, 2024

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Companion to Homebrew/brew#16622. I've checked all these formulae:

  • For gnupg2, qt5, and pyqt5: the rename and the alias were added separately. I removed the aliases in favour of the formula_renames.json entries.
  • For linux-headers: the formula_renames.json entry points to linux-headers@4.4 but the alias points to linux-headers@5.15. I removed the formula_renames.json entry to preserve the current behaviour (linux-headers points to 5.15).
  • For the rest of them, the commit that renamed the formula also introduced an alias with the old name. For these formulae, I also removed the aliases in favour of the entries present in formula_renames.json.

The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
There is already a `linux-headers` alias pointing to
`linux-headers@5.15`, so the entry here is not used anymore.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
The alias is present in `formula_renames.json`.
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 9, 2024
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@p-linnane p-linnane added this pull request to the merge queue Feb 9, 2024
Merged via the queue into Homebrew:master with commit 73037b1 Feb 9, 2024
14 checks passed
@reitermarkus
Copy link
Member

Thanks!

@ZhongRuoyu ZhongRuoyu deleted the remove-aliases-renames branch February 10, 2024 05:38
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants