Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy: use build_isolation to remove meson-python #165470

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Mar 8, 2024
@github-actions github-actions bot added CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels Mar 8, 2024
@p-linnane p-linnane added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Mar 8, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 8, 2024
@chenrui333
Copy link
Member

            × Building wheel for patchelf (pyproject.toml) did not run successfully.
            │ exit code: 1
            ╰─> [11 lines of output]
                Traceback (most recent call last):
                  File "/tmp/pip-build-env-q120om8q/overlay/lib/python3.11/site-packages/skbuild/setuptools_wrap.py", line 645, in setup
                    cmkr = cmaker.CMaker(cmake_executable)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                  File "/tmp/pip-build-env-q120om8q/overlay/lib/python3.11/site-packages/skbuild/cmaker.py", line 148, in __init__
                    self.cmake_version = get_cmake_version(self.cmake_executable)
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                  File "/tmp/pip-build-env-q120om8q/overlay/lib/python3.11/site-packages/skbuild/cmaker.py", line 105, in get_cmake_version
                    raise SKBuildError(msg) from err
  
                Problem with the CMake installation, aborting build. CMake executable is cmake
                [end of output]
  
            note: This error originates from a subprocess, and is likely not a problem with pip.
            ERROR: Failed building wheel for patchelf
          Failed to build patchelf
          ERROR: Could not build wheels for patchelf, which is required to install pyproject.toml-based projects
          [end of output]

@chenrui333 chenrui333 added build failure CI fails while building the software linux Linux is specifically affected labels Mar 10, 2024
@cho-m cho-m force-pushed the numpy-isolated-build branch 2 times, most recently from 9e0e5fd to 7b7b8cd Compare March 12, 2024 03:24
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 12, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 12, 2024
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 13, 2024
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m removed build failure CI fails while building the software linux Linux is specifically affected labels Mar 13, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Mar 13, 2024
@fxcoudert fxcoudert added the ready to merge PR can be merged once CI is green label Mar 13, 2024
@fxcoudert
Copy link
Member

The root failure with new SDK headers is sadly common. Everything else is fine, so I'm in favour of merging as is.

@cho-m
Copy link
Member Author

cho-m commented Mar 13, 2024

We were informed of root failure in issue #165757. It's a bit tricky that Xcode.app upgrade may break runtime behavior. Anyway, CI failure isn't related to numpy so should be good to merge.

@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 13, 2024
Merged via the queue into master with commit 66d8ad0 Mar 13, 2024
29 of 31 checks passed
@BrewTestBot BrewTestBot deleted the numpy-isolated-build branch March 13, 2024 12:14
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants