flint 3.1.3 #166490

edgarcosta · 2024-03-18T15:36:16Z

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

I'm not sure what you would like me to do about:

flint

line 39, col 5: Formulae should be verified as having support for runtime hardware detection before using ENV.runtime_cpu_detection.
Error: 1 problem in 1 formula detected.

depends on #166574

SMillerDev · 2024-03-19T08:51:22Z

Can you make disabling ARB a different PR? That should solve the issue I believe

edgarcosta · 2024-03-19T14:01:40Z

#166574 has been merged, so no longer issues with arb, but I still do not know how to address

Formulae should be verified as having support for runtime hardware detection before using ENV.runtime_cpu_detection.

Formula/f/flint.rb

edgarcosta · 2024-03-22T13:19:37Z

@SMillerDev, thanks for the suggestion, I have also incorporated @albinahlback suggestion, but I still do not know how to address:

Formulae should be verified as having support for runtime hardware detection before using ENV.runtime_cpu_detection.

chenrui333 · 2024-04-03T17:38:18Z

cc @caarlos0 for thoughts.

caarlos0 · 2024-04-03T17:45:50Z

cc @caarlos0 for thoughts.

wrong cc maybe? I know nothing about flint or the underlying issue

edgarcosta · 2024-04-03T18:43:30Z

The underlying issue is the warning:

Formulae should be verified as having support for runtime hardware detection before using ENV.runtime_cpu_detection

edgarcosta · 2024-04-04T15:01:06Z

I figured it out; one needs to add flint to style_exceptions/runtime_cpu_detection_allowlist.json

edgarcosta · 2024-04-16T18:07:59Z

I am honestly confused about the error message,

No `cpuid` instruction detected. flint should not use `ENV.runtime_cpu_detection`.

as FLINT uses cpuid, see: https://github.com/flintlib/flint/blob/main/config/config.guess#L797

FLINT has changed repo to https://github.com/flintlib/flint This also now has releases, and the current version is 3.1.3 Setting livecheck to use github_latest Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>

edgarcosta · 2024-05-13T20:37:32Z

I think I fixed everything now, and this is ready to review

mahrud · 2024-05-14T22:46:40Z

Formula/f/flint.rb

  uses_from_macos "m4" => :build

  def install
+    # to build against NTL


NTL doesn't appear anywhere else in the formula now, is this correct?

Yes. We have a header-only interface.

and the NTL interface header is a C++ header

mahrud · 2024-05-14T23:00:14Z

Formula/f/flint.rb

+        args << "--enable-arch=#{Hardware.oldest_cpu}"
+      elsif Hardware::CPU.avx2?
+        # TODO: enable avx512 support
+        args << "--enable-avx2"


Flint doesn't use BLAS yet, right? If it did, Apple's Accelerate framework has SIMD vector operations that replace avx: https://developer.apple.com/documentation/accelerate/simd

We do use it in multiplication for the nmod_mat and fmpz_mat modules.

Edit: BLAS, that is.

BLAS is optional; we could compile against it and add it as a dependency.
@albinahlback and @fredrik-johansson, is this something that we want?

carlocab

Thanks; great work!

github-actions · 2024-05-18T16:25:27Z

🤖 An automated task has requested bottles to be published to this PR.

dimpase · 2024-05-21T21:09:59Z

pkg-config --modversion flint returns 3.1.0 instead of 3.1.3.
For some reason the version is not bumped up, not sure it's here or upstream.

cho-m · 2024-05-21T21:36:02Z

pkg-config --modversion flint returns 3.1.0 instead of 3.1.3. For some reason the version is not bumped up, not sure it's here or upstream.

Probably should open issue upstream for CI workflow relating to release tarballs to make sure VERSION file is modified before bootstrap.sh is run.

The problem looks like reverse is happening so configure contains:

PACKAGE_VERSION='3.1.0'
PACKAGE_STRING='FLINT 3.1.0'
...
FLINT_VERSION_FULL=3.1.0

https://github.com/flintlib/flint/blob/main/.github/workflows/release.yml#L88-L93

      - name: "Bootstrap"
        run: |
          ./bootstrap.sh

      - name: "Create source archive"
        run: dev/make_dist.sh ${FLINT_VERSION}

https://github.com/flintlib/flint/blob/main/dev/make_dist.sh#L39-L40

# update VERSION file
printf $flint_version > VERSION

edgarcosta · 2024-05-22T03:46:41Z

I have submitted two PRs to fix the problem upstream: flintlib/flint#1993 and flintlib/flint#1994 (which FLINT releases if 3.1.4 will exist)

carlocab · 2024-05-22T03:55:54Z

Thanks! Feel free to open a PR that backports those patches to the current version of the formula.

github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 18, 2024

edgarcosta force-pushed the flint3 branch from 610b22a to e1dc521 Compare March 19, 2024 10:17

edgarcosta changed the title ~~uptading FLINT (git, download, and bumping version) and disable arb~~ uptading FLINT (git, download, and bumping version) Mar 19, 2024

edgarcosta force-pushed the flint3 branch from e1dc521 to f7e5fcd Compare March 19, 2024 10:34

github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Mar 19, 2024

edgarcosta force-pushed the flint3 branch 2 times, most recently from 6d00995 to 9fec260 Compare March 19, 2024 10:59

github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Mar 19, 2024

edgarcosta changed the title ~~uptading FLINT (git, download, and bumping version)~~ updating FLINT (git, download, and bumping version) Mar 19, 2024

edgarcosta force-pushed the flint3 branch 2 times, most recently from 89cf498 to 56a2ee6 Compare March 19, 2024 13:53

github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 19, 2024

albinahlback reviewed Mar 22, 2024

View reviewed changes

Formula/f/flint.rb Outdated Show resolved Hide resolved

SMillerDev reviewed Mar 22, 2024

View reviewed changes

Formula/f/flint.rb Outdated Show resolved Hide resolved

SMillerDev changed the title ~~updating FLINT (git, download, and bumping version)~~ flint 3.1.2 Mar 22, 2024

github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Mar 22, 2024

edgarcosta force-pushed the flint3 branch from daea517 to 20d9372 Compare March 22, 2024 13:00

github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Mar 22, 2024

edgarcosta force-pushed the flint3 branch from 20d9372 to 420895e Compare April 4, 2024 15:00

github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 4, 2024

edgarcosta force-pushed the flint3 branch 2 times, most recently from ae8d289 to fff22f6 Compare April 4, 2024 22:05

github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 10, 2024

edgarcosta force-pushed the flint3 branch 2 times, most recently from 034e728 to e699748 Compare May 10, 2024 18:43

edgarcosta changed the title ~~flint 3.1.2~~ flint 3.1.3 May 13, 2024

edgarcosta force-pushed the flint3 branch from e699748 to c73c262 Compare May 13, 2024 20:24

flint: uptading git, download, and version

78d319c

FLINT has changed repo to https://github.com/flintlib/flint This also now has releases, and the current version is 3.1.3 Setting livecheck to use github_latest Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>

edgarcosta force-pushed the flint3 branch from c73c262 to 78d319c Compare May 13, 2024 20:32

github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 13, 2024

mahrud reviewed May 14, 2024

View reviewed changes

carlocab approved these changes May 18, 2024

View reviewed changes

flint: update 3.1.3 bottle.

4109cbe

github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 18, 2024

github-actions bot approved these changes May 18, 2024

View reviewed changes

BrewTestBot enabled auto-merge May 18, 2024 16:26

carlocab removed the stale No recent activity label May 18, 2024

BrewTestBot added this pull request to the merge queue May 18, 2024

Merged via the queue into Homebrew:master with commit bc17c84 May 18, 2024
16 checks passed

edgarcosta mentioned this pull request May 21, 2024

build/pkgs/flint/spkg-configure.m4: Reject broken FLINT package on homebrew sagemath/sage#38021

Merged

5 tasks

edgarcosta mentioned this pull request May 22, 2024

move bootstrap to dev/make_dist.sh flintlib/flint#1993

Merged

edgarcosta mentioned this pull request May 22, 2024

Could we release 3.1.3-p1? flintlib/flint#1996

Closed

github-actions bot added the outdated PR was locked due to age label Jun 24, 2024

github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flint 3.1.3 #166490

flint 3.1.3 #166490

edgarcosta commented Mar 18, 2024 •

edited

Loading

SMillerDev commented Mar 19, 2024

edgarcosta commented Mar 19, 2024

edgarcosta commented Mar 22, 2024

chenrui333 commented Apr 3, 2024

caarlos0 commented Apr 3, 2024

edgarcosta commented Apr 3, 2024

edgarcosta commented Apr 4, 2024

edgarcosta commented Apr 16, 2024

edgarcosta commented May 13, 2024

mahrud May 14, 2024

albinahlback May 14, 2024

edgarcosta May 15, 2024

mahrud May 14, 2024

albinahlback May 14, 2024 •

edited

Loading

edgarcosta May 15, 2024

carlocab left a comment

github-actions bot commented May 18, 2024

dimpase commented May 21, 2024

cho-m commented May 21, 2024 •

edited

Loading

edgarcosta commented May 22, 2024

carlocab commented May 22, 2024

flint 3.1.3 #166490

flint 3.1.3 #166490

Conversation

edgarcosta commented Mar 18, 2024 • edited Loading

SMillerDev commented Mar 19, 2024

edgarcosta commented Mar 19, 2024

edgarcosta commented Mar 22, 2024

chenrui333 commented Apr 3, 2024

caarlos0 commented Apr 3, 2024

edgarcosta commented Apr 3, 2024

edgarcosta commented Apr 4, 2024

edgarcosta commented Apr 16, 2024

edgarcosta commented May 13, 2024

mahrud May 14, 2024

Choose a reason for hiding this comment

albinahlback May 14, 2024

Choose a reason for hiding this comment

edgarcosta May 15, 2024

Choose a reason for hiding this comment

mahrud May 14, 2024

Choose a reason for hiding this comment

albinahlback May 14, 2024 • edited Loading

Choose a reason for hiding this comment

edgarcosta May 15, 2024

Choose a reason for hiding this comment

carlocab left a comment

Choose a reason for hiding this comment

github-actions bot commented May 18, 2024

dimpase commented May 21, 2024

cho-m commented May 21, 2024 • edited Loading

edgarcosta commented May 22, 2024

carlocab commented May 22, 2024

edgarcosta commented Mar 18, 2024 •

edited

Loading

albinahlback May 14, 2024 •

edited

Loading

cho-m commented May 21, 2024 •

edited

Loading