-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move bootstrap to dev/make_dist.sh #1993
Conversation
Yeah, seems like I never updated the VERSION file for any patch I made. If it works, please merge when you feel it is ready. |
I think I will need to make a couple more changes. I triggered a release using this branch on my fork: https://github.com/edgarcosta/flint/releases/tag/v3.1.3-p1
but the VERSION file still says 3.1.0 😭 |
Why don't you use ./configure to fill VERSION in ? |
@dimpase where would ./configure get that information from? |
how does one obtain the correct version in |
this does not look plausible - then PACKAGE_VERSION would still be 3.1.0, not what is shown above. |
I am not sure what the problem is - for me, on the current By the way, it would be prudent to bump the minimal autoconf version in |
Releases are triggered via git tags, not necessarily by changing the file Now, we do |
In particular, moved
printf $flint_version > VERSION
before./bootstrap.sh
See: Homebrew/homebrew-core#166490 (comment)
and sagemath/sage#38048