Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw-w64: fix build with Xcode 15.3 #169892

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

mrpippy
Copy link
Contributor

@mrpippy mrpippy commented Apr 23, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Backport two GCC patches (by @fxcoudert) that fix building from source with Xcode 15.3. (#167872 is failing because of them).

@mrpippy
Copy link
Contributor Author

mrpippy commented Apr 24, 2024

Rebased to see if the spurious CI failure resolves itself

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 24, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 24, 2024
Merged via the queue into Homebrew:master with commit 4a94ba7 Apr 24, 2024
14 checks passed
@adfoster-r7
Copy link

adfoster-r7 commented May 8, 2024

Hi there; I appear to be getting this issue locally - just wanted to confirm if that sha is correct 👀

==> Downloading https://gcc.gnu.org/git/?p=gcc.git;a=patch;h=9970b576b7e4ae337af1268395ff221348c4b34a
Already downloaded: /Users/vagrant/Library/Caches/Homebrew/downloads/6c68aa4aef135895a658b1ab6d97313af8eadb8add341ff7a61b747317d00608--gcc.git-9970b576b7e4ae337af1268395ff221348c4b34a.patch
Error: mingw-w64: SHA256 mismatch
Expected: 968bfcb58f75d889470f2f815787f6aa254fb43f1e5516e04f577dad22259905
  Actual: 7f79e6bf59d58562990baaed5a69f83df57e6d6255a3ddf5c779320e58dd5f30
    File: /Users/vagrant/Library/Caches/Homebrew/downloads/6c68aa4aef135895a658b1ab6d97313af8eadb8add341ff7a61b747317d00608--gcc.git-9970b576b7e4ae337af1268395ff221348c4b34a.patch
To retry an incomplete download, remove the file above.

Also verified via the host:

$ curl -s https://gcc.gnu.org/git/\?p\=gcc.git\;a\=patch\;h\=9970b576b7e4ae337af1268395ff221348c4b34a | sha256sum
7f79e6bf59d58562990baaed5a69f83df57e6d6255a3ddf5c779320e58dd5f30  -

@adfoster-r7 adfoster-r7 mentioned this pull request May 8, 2024
4 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants