octave: fix opengl-partial-update bug #170628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
autosquash
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
Seems like it fails to build now |
|
Not sure here. I only touch libgui/graphics/GLCanvas.cc with the patch. I don't know why this isn't building. Does it build without the upstream patch form Markus? |
|
Could this be due to the fact that I didn't update the revision 2 to revision 3?
…On Thu, May 2, 2024 at 1:31 PM Sean Molenaar ***@***.***> wrote:
src/octave-svgconvert.cc:42:10: fatal error: 'QApplication' file not found
Seems like it fails to build now
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
carlocab
changed the title
It should build, but let's see... |
Please test this. I don't have a homebrew system and this is my first wack at ruby code. I copied the patch command from ocaml@4.rb, updated the sha256sum and linked in the patch from savannah.gnu.org. Hope this helps. Chris
carlocab
added
the
CI-no-fail-fast
|
Build failure and OpenGL bug will be fixed in #170657. Thanks @chrisjohgorman! |
|
Hi Carlo,
Thank you for taking this over and committing it.
All the best,
Chris
…On Thu, May 2, 2024 at 6:02 PM Carlo Cabrera ***@***.***> wrote:
Closed #170628 <#170628>.
—
Reply to this email directly, view it on GitHub
<#170628 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG76X4ZM4DL7SA6IO5NUGITZAKZWRAVCNFSM6AAAAABHECBXJKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGY4DSOBXGM2TKNY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
No problem. Thanks for taking the time to trying to get this fixed! |
|
Glad to help. All the best.
…On Fri, May 3, 2024 at 11:19 AM Carlo Cabrera ***@***.***> wrote:
No problem. Thanks for taking the time to trying to get this fixed!
—
Reply to this email directly, view it on GitHub
<#170628 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG76X42MQBTXARRNBQLJBZDZAOTJTAVCNFSM6AAAAABHECBXJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGIZTAOBSGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sorry for the extra email. But I thought you might like to know that I
have a report of figure() and plot() working now with octave from homebrew.
Take care,
Chris
On Fri, May 3, 2024 at 11:27 AM Chris Gorman ***@***.***>
wrote:
… Glad to help. All the best.
On Fri, May 3, 2024 at 11:19 AM Carlo Cabrera ***@***.***>
wrote:
> No problem. Thanks for taking the time to trying to get this fixed!
>
> —
> Reply to this email directly, view it on GitHub
> <#170628 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AG76X42MQBTXARRNBQLJBZDZAOTJTAVCNFSM6AAAAABHECBXJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGIZTAOBSGA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test this. I don't have a homebrew system and this is my first wack at ruby code. I copied the patch command from ocaml@4.rb, updated the sha256sum and linked in the patch from savannah.gnu.org.
Hope this helps.
Chris
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?fixes #170616