Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octave: fixes for Qt 6.7.0 #170657

Merged
merged 2 commits into from
May 3, 2024
Merged

octave: fixes for Qt 6.7.0 #170657

merged 2 commits into from
May 3, 2024

Conversation

fxcoudert
Copy link
Member

Fixes #170616

@fxcoudert fxcoudert marked this pull request as ready for review May 2, 2024 21:23
@github-actions github-actions bot added the java Java use is a significant feature of the PR or issue label May 2, 2024
@chenrui333
Copy link
Member

duplicate of #170628?

@fxcoudert
Copy link
Member Author

I didn't see #170628
But it only has part of the fix

@carlocab carlocab mentioned this pull request May 2, 2024
Closed
6 tasks
@chenrui333
Copy link
Member

I didn't see #170628 But it only has part of the fix

all good 👍

@fxcoudert fxcoudert added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 3, 2024
@fxcoudert
Copy link
Member Author

dynare test failure is due to Homebrew/brew#17203

@fxcoudert fxcoudert added the ready to merge PR can be merged once CI is green label May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 3, 2024
@BrewTestBot BrewTestBot enabled auto-merge May 3, 2024 09:42
@carlocab carlocab mentioned this pull request May 3, 2024
Closed
4 tasks
@BrewTestBot BrewTestBot added this pull request to the merge queue May 3, 2024
Merged via the queue into Homebrew:master with commit 5d9f72c May 3, 2024
14 checks passed
@fxcoudert fxcoudert deleted the octave branch May 3, 2024 10:10
apjanke
apjanke reviewed May 6, 2024
View reviewed changes
Formula/o/octave.rb
depends_on "gnu-sed" => :build # https://lists.gnu.org/archive/html/octave-maintainers/2016-09/msg00193.html
depends_on "libtool" => :build # for the patches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Qt 6.7 problem!

Out of curiosity:

image

This addition of depends_on "libtool" => :build seems redundant with the existing plain (non-:build) depends_on "libtool" further down. The main (not on_linux) depends_on list now looks like this to me:

  depends_on "libtool" => :build # for the patches
[...]
  depends_on "libtool"

Does the :build version of the depends_on do something special here? I thought that all the regular depends_on dependencies were also installed/available at build time, and the :build dependencies meant "only install this when doing a build of this formula, but don't install it when installing the package from a bottle.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a mistake

@apjanke apjanke mentioned this pull request May 6, 2024
Open
3 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apjanke apjanke apjanke left review comments

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. java Java use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Octave 9.1.0 opengl bug interacting with qt6-6.7.0
5 participants
@fxcoudert @chenrui333 @apjanke @carlocab @BrewTestBot