Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipopt: add mumps headers to install #171266

Closed
wants to merge 1 commit into from
Closed

ipopt: add mumps headers to install #171266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Formula/i/ipopt.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ def install
"libseq/#{shared_library("*")}",
"PORD/lib/#{shared_library("*")}"
]
# install headers
libexec.install "include"
(libexec/"include").install Dir["libseq/*.h"]
include.install_symlink Dir[libexec/"include/*"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just directly installing them into include instead of installing into libexec and then creating symlinks?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to differentiate core ipopt headers from headers vendored from a dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, why not install things into a mumps subdirectory?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming really isn't that important to me (mumps vs libexec just so long as they're symlinked into include, I'll renamed to mumps.

end

args = [
Expand Down
Loading