Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freerdp: add linked indirect dependencies #171794

Merged
merged 1 commit into from
May 15, 2024
Merged

freerdp: add linked indirect dependencies #171794

merged 1 commit into from
May 15, 2024

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented May 15, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Seen in: Homebrew/homebrew-core/actions/runs/9094160676?pr=171740

I'm not sure if the gcc linkage is correct here, or is the part of Homebrew/brew#17303

@bevanjkay bevanjkay added the CI-no-bottles Merge without publishing bottles label May 15, 2024
@github-actions github-actions bot added icu4c ICU use is a significant feature of the PR or issue ffmpeg FFMPEG use is a significant feature of the PR or issue labels May 15, 2024
@bevanjkay bevanjkay requested a review from carlocab May 15, 2024 14:29
@Bo98
Copy link
Member

Bo98 commented May 15, 2024

Ignore GCC for now

Formula/f/freerdp.rb Outdated Show resolved Hide resolved
Formula/f/freerdp.rb Outdated Show resolved Hide resolved
@bevanjkay bevanjkay marked this pull request as ready for review May 15, 2024 14:33
@BrewTestBot BrewTestBot added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 95d39af May 15, 2024
24 checks passed
@BrewTestBot BrewTestBot deleted the freerdp-deps branch May 15, 2024 15:46
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles ffmpeg FFMPEG use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants