marathon-swift 1.0.1 (new formula)

[orta]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

Adds Marathon: https://github.com/JohnSundell/Marathon

[orta]

Ah dang, I thought that linter error was just me setting up my local dev env wrong. Interesting, will discuss with the maintainers about naming.

[orta]

Awesome, we're green 👍

[ilovezfs]

This is set automatically.

[ilovezfs]

Let's leave out the emoji

[ilovezfs]

Please request a make install upstream.

[ilovezfs]

This needs to be a test that exercises and verifies the functionality of the software once installed.

[orta]

@ilovezfs - I've shipped ~10 force-commits to address your feedback, but do you know if there's anything unique about the Sierra and using the install command? I've tried building out a make command for installing the app that calls:

PREFIX?=/usr/local
INSTALL_NAME = marathon

# [...]

install_bin:
	mkdir -p $(PREFIX)/bin
	mv .build/Release/Marathon .build/Release/$(INSTALL_NAME)
	/usr/bin/install -s -m 0755 .build/Release/$(INSTALL_NAME) $(PREFIX)/bin

But it only fails on Sierra, and when I tried using cp it was the same story. This is my first time making cask / using Makefiles for system setup, so am I missing something simple?

[orta]

@ilovezfs this is now green 👍

[orta]

Polite Poke

[ilovezfs]

Thanks for your first contribution to Homebrew @orta! Without people like you submitting PRs we couldn't run this project. You rock!

[orta]

No - you rock - thanks!

[JohnSundell]

@orta @ilovezfs you both rock 🎸 Thanks a lot for this!