Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust 1.80.0 #178436

Merged
merged 2 commits into from
Aug 1, 2024
Merged

rust 1.80.0 #178436

merged 2 commits into from
Aug 1, 2024

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Jul 25, 2024 •
edited by chenrui333
Loading

Created by brew bump

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Jul 25, 2024
@SMillerDev
Copy link
Member

Can we bump libgit in this one?

@chenrui333
Copy link
Member

chenrui333 commented Jul 25, 2024 •
edited
Loading

Can we bump libgit in this one?

looks like still using libgit2 1.7

/opt/homebrew/opt/libgit2@1.7/lib/libgit2.1.7.dylib (libgit2@1.7)

it would be avail in 1.81.0, relates to https://github.com/rust-lang/rust/pull/126507 (I can followup with a note for the future bump)

@branchvincent branchvincent mentioned this pull request Jul 26, 2024
Closed
@chenrui333 chenrui333 added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Jul 26, 2024
@chenrui333 chenrui333 mentioned this pull request Jul 27, 2024
Merged
@BrewTestBot @chenrui333
rust 1.80.0
f389681 
rust: cargo 0.81.0 and bootstrap 2024-06-13/1.79.0

Signed-off-by: Rui Chen <rui@chenrui.dev>

rust: add note about libgit2 1.8

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 mentioned this pull request Jul 29, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 30, 2024
@branchvincent branchvincent added in progress Stale bot should stay away and removed stale No recent activity labels Jul 30, 2024
@jayvdb
Copy link

jayvdb commented Jul 30, 2024

Do we know why CI is failing?

@branchvincent
Copy link
Member 

Error: 91 failed steps!

Doesn't look great 😅 58 are from time-rs/time#681 and fixed a while back in time-rs/time@5b0c627

@jayvdb
Copy link

jayvdb commented Jul 30, 2024

Could we have two versions of rust? one used to build other rust formula, and one that is the latest. Having only one creates a bit of a catch-22 - cant get the latest rust using brew, so cant use the latest to fix the crates that are broken. (Can use rustup of course)

carlocab
carlocab approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to fix dependent failures in follow-ups.

This was referenced Jul 30, 2024
Merged
Closed
Merged
Merged
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jul 31, 2024
This was referenced Jul 31, 2024
Merged
Merged
@chenrui333
Copy link
Member

let's ship out and followup on the build/test failures.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 1, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit e684ec5 Aug 1, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-rust-1.80.0 branch August 1, 2024 16:31
chenrui333 referenced this pull request in yarrow/zet Aug 1, 2024
@yarrow
Take nightly clippy advice
b6a0c67
@chenrui333
Copy link
Member

chenrui333 commented Aug 1, 2024 •
edited
Loading

tracker

time crate

main issue, time-rs/time#693 (need to bump to 0.3.36)

This was referenced Aug 1, 2024
Closed
Merged
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@carlocab carlocab carlocab approved these changes

@github-actions GitHub Actions github-actions approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BrewTestBot @SMillerDev @chenrui333 @jayvdb @branchvincent @carlocab