Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gifski 0.3.0 (new formula) #20241

Closed
wants to merge 2 commits into from
Closed

gifski 0.3.0 (new formula) #20241

wants to merge 2 commits into from

Conversation

danielbayley
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@woodruffw woodruffw added the new formula PR adds a new formula to Homebrew/homebrew-core label Nov 4, 2017
@woodruffw
Copy link
Member

Sorry, but we can't merge this into homebrew-core, per our notability tests:

gifski:
  * GitHub repository too new (<30 days old)

If you'd still like to install it via brew, I suggest setting up a custom tap.

@kornelski
Copy link
Contributor

Suggestions for the formula:

  • test with at least 2 png files (1 file will be interpreted as a video and give an error)

  • consider compiling with CC=gcc-7 cargo build --release --features=openmp. With OpenMP it's 50% faster (but needs gcc, because OpenMP doesn't work with Xcode's clang).

@danielbayley
Copy link
Contributor Author

danielbayley commented Nov 24, 2017

@pornel I've checked Allow edits from maintainers so if someone wants to pick this up…

@danielbayley
Copy link
Contributor Author

@woodruffw Reopen?

@woodruffw
Copy link
Member

@danielbayley Reopened!

Looks like gifski is currently on 0.6.2.

@woodruffw woodruffw reopened this Dec 8, 2017
@danielbayley
Copy link
Contributor Author

@woodruffw Updated. @pornel Want to chip in?

@kornelski
Copy link
Contributor

The test is invalid, as per my previous comment

@ilovezfs ilovezfs added the ready to merge PR can be merged once CI is green label Dec 14, 2017
@fxcoudert
Copy link
Member

Thanks @danielbayley for your contribution to Homebrew! 🎊

@fxcoudert fxcoudert closed this in 07cdc37 Dec 14, 2017
@danielbayley
Copy link
Contributor Author

@fxcoudert Ah cool, you beat me to it! No worries.

@danielbayley danielbayley deleted the gifski branch December 14, 2017 15:10
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants