Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamav: make pcre recommended #2093

Closed
wants to merge 1 commit into from
Closed

clamav: make pcre recommended #2093

wants to merge 1 commit into from

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Jun 18, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

It's actually pretty important at runtime & clamav will throw irritating warnings that it's missing at every opportunity without it. Ref: #1900

Since pcre is already an epidemic in Homebrew, spreading it a little further probably won't catch many additional users.

It's actually pretty important at runtime & clamav will throw irritating
warnings that it's missing at every opportunity without it. Ref: #1900

Since `pcre` is already an epidemic in Homebrew, spreading it a little further
probably won't catch many additional users.
@BrewTestBot BrewTestBot added the in progress Stale bot should stay away label Jun 18, 2016
@ilovezfs
Copy link
Contributor

👍

@ilovezfs
Copy link
Contributor

I think you may have read my mind on this one.

@DomT4
Copy link
Member Author

DomT4 commented Jun 18, 2016

I put it on my mental list a while ago because someone highlighted the issue on our security mailing list (Wrong place to highlight this particular issue, but still) and then like most things I put on my mental list it escaped 🙈.

@DomT4 DomT4 closed this in 00dc6d0 Jun 18, 2016
@BrewTestBot BrewTestBot removed the in progress Stale bot should stay away label Jun 18, 2016
@DomT4 DomT4 deleted the clamav branch June 18, 2016 03:06
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants