Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua@5.3: revision bump to fix dylib & pc versioning #21297

Closed
wants to merge 2 commits into from
Closed

lua@5.3: revision bump to fix dylib & pc versioning #21297

wants to merge 2 commits into from

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Dec 3, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Split from #21282.

@ilovezfs
Copy link
Contributor

ilovezfs commented Dec 3, 2017

2 of 4

@ilovezfs
Copy link
Contributor

ilovezfs commented Dec 3, 2017

At some point the dylib thing needs to get upstreamed …

@DomT4
Copy link
Member Author

DomT4 commented Dec 3, 2017

Aye, indeed. It’s on my list. I seem to have adopted the Lua formulae over the years & unlike the Node stuff very few others have stepped forwards to help out.

@ilovezfs
Copy link
Contributor

ilovezfs commented Dec 3, 2017

is macports doing the same patching?

@DomT4
Copy link
Member Author

DomT4 commented Dec 3, 2017

Slightly different way, but essentially, yes and yes.

@ilovezfs
Copy link
Contributor

ilovezfs commented Dec 3, 2017

#sad

@DomT4
Copy link
Member Author

DomT4 commented Dec 3, 2017

Aye. The ship has almost certainly sailed on ever getting 5.1 and 5.2 fixed but if someone upstreams it maybe we can get something in the next version of 5.3, maybe 😓.

@ilovezfs ilovezfs closed this in 81bf86e Dec 3, 2017
@ilovezfs
Copy link
Contributor

ilovezfs commented Dec 3, 2017

🍪

@DomT4 DomT4 deleted the lua@5.3 branch December 3, 2017 16:29
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
stilvoid pushed a commit to stilvoid/homebrew-core that referenced this pull request Oct 21, 2020
Closes Homebrew#21297.

Signed-off-by: Dawid Dziurla <dawidd0811@gmail.com>
Signed-off-by: Michka Popoff <3406519+iMichka@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants