lua@5.1 & lua: update luarocks to 2.4.4 #21282

DomT4 · 2017-12-02T20:56:46Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

I should've jumped on top of this a while ago, apologies.

DomT4 · 2017-12-02T21:02:18Z

Don't merge this straight away, looking into a something.

DomT4 · 2017-12-03T01:08:34Z

Alright, this should be good to 🚢 whenever you're happy & CI is happy @ilovezfs. In way of explanation:

I knew upstream had fixed the old permissions problem but it wasn't in the current release as listed at the https://keplerproject.github.io/luarocks/releases/ URL, so I updated to what that said was the latest release, which still had the permission issues.
Checking the main luarocks website led me to realise the https://keplerproject.github.io/luarocks/releases/ was no longer updating with the latest releases, and that instead releases were now being hosted at https://luarocks.github.io/luarocks/releases/.
Testing that latest release confirmed the permissions fix had been folded in & is available, resolving issues such as the one vis upstream mentioned in this comment.

(We put the Christmas decorations up at uni since we're all only here for another couple weeks; the above list didn't take me 4 hours to get through 😄)

DomT4 · 2017-12-03T01:32:13Z

Oh, new problem. How fun. Looking into it, again.

DomT4 · 2017-12-03T06:47:26Z

This is "Not great" ™️ but my recommendation is that it is still better than the status quo, and resolves several issues not only around luarocks handling but with the lua@5.3 formula, and is worth pressing ahead with.

I intend to wander upstream later today and try to initiate some kind of conversation around the issues discovered trying to get it to build the old way, and indeed test whether they're already been resolved in master or not.

ilovezfs · 2017-12-03T14:32:25Z

I think I'd prefer we not do this. Build steps in post_install are basically a formula bug.

DomT4 · 2017-12-03T14:47:02Z

If necessary I’ll split this into two PRs whilst I talk to upstream, since the Lua formula here remains working as-is. It’s the versioned stuff there’s some issues around.

DomT4 · 2017-12-03T14:48:02Z

Actually 3 PRs maybe, the Lua@5.3 patch & pkg-config updates probably shouldn’t wait much longer sigh.

ilovezfs · 2017-12-03T14:52:48Z

I demand at least 4 PRs.

DomT4 · 2017-12-03T15:28:46Z

I mean, I could probably manage it if you're desperate 😉.

ilovezfs · 2017-12-03T15:30:00Z

Must … have … PR … It's like 🚰

ilovezfs · 2017-12-03T16:27:28Z

What is this conflicted PR I see?

DomT4 · 2017-12-03T16:34:14Z

Don't know to what you refer to 😉.

ilovezfs

👋 post_install

ilovezfs · 2017-12-03T22:30:17Z

So is the issue here just about the luarocks build reporting it cannot find lua?

DomT4 · 2017-12-03T22:36:53Z

Yeah. They seem to have broken detection of versioned executables, and even if you hack around that problem you hit a second problem that it thinks the header version doesn't align with the executable version because it thinks the executable version is null, for some reason 🙃.

ilovezfs · 2017-12-03T22:40:22Z

I think it's just that

bash-3.2$ /usr/local/Cellar/lua/5.3.4/bin/lua --version
dyld: Library not loaded: /usr/local/lib/liblua.5.3.dylib
  Referenced from: /usr/local/Cellar/lua/5.3.4/bin/lua
  Reason: image not found
Trace/BPT trap: 5
bash-3.2$ exit

since the patch is using HOMEBREW_PREFIX/lib/liblua.5.3.dylib not @LUA_PREFIX@/lib/liblua.5.3.dylib

DomT4 · 2017-12-03T22:42:14Z

Yeah, that was what I ran into last night poking around but ran out of time to test fixes before I had to die for the day.

DomT4 · 2017-12-03T22:43:01Z

The post_install change was essentially something I knew would work and I could put together in 2 minutes, and probably wouldn't be awful until I had a moment to test things in more detail 😄.

ilovezfs · 2017-12-03T22:43:02Z

ah ok … I'm just saying I'm not sure they actually broke anything.

DomT4 · 2017-12-03T22:44:31Z

Something changed upstream, I presume, as this wasn't an issue till recently, but yeah it could just be amongst the detection tweaks they tripped a wire that had been sat there for us quietly for quite some time 🙈.

ilovezfs · 2017-12-03T22:45:18Z

The same s.gsub! "@LUA_PREFIX@", prefix will probably work.

DomT4 · 2017-12-03T22:46:06Z

I'll be back online properly in a few hours & can take a peek then, if you like.

ilovezfs · 2017-12-03T22:47:11Z

np

DomT4 · 2017-12-03T22:52:34Z

If you want to leap over me by all means don't feel obligated to wait or anything, but yeah, happy to poke around later if you're not chomping at the bit to have at it.

stale · 2018-03-07T16:59:45Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

DomT4 · 2018-03-07T22:43:21Z

If you've got ideas on resolving this without leaning on postinstall to do a stupid dance Stalebot, I'm all ears.

DomT4 · 2018-03-08T02:22:00Z

I guess that serves as CI confirmation that I'm not just having some weird local issue at least.

DomT4 · 2018-03-23T01:27:41Z

So. This PR should return green now. Finally.

DomT4 · 2018-03-23T01:30:25Z

The amount of wrong directions the configure failures sent me down was borderline ridiculous on this PR. What a grim use of time.

ilovezfs · 2018-03-23T01:30:15Z

Formula/lua@5.1.rb

@@ -40,14 +40,17 @@ class LuaAT51 < Formula
    end
  end

+  # Don't use the https://luarocks.org/releases/luarocks-x.y.z.tar.gz URL


comment looks wrong

Oh, maybe they've fixed the redirect now. I'll check.

Still there:

Resource: luarocks ==> Downloading https://luarocks.org/releases/luarocks-2.4.4.tar.gz ==> Downloading from http://luarocks.github.io/luarocks/releases/luarocks-2.4.4.tar.gz /usr/bin/curl --show-error --user-agent Homebrew/1.5.12-9-g49927ed (Macintosh; Intel Mac OS X 10.13.4) curl/7.54.0 --fail --location --remote-time --continue-at - --output /usr/local/var/homebrewcache/lua--luarocks-2.4.4.tar.gz.incomplete http://luarocks.github.io/luarocks/releases/luarocks-2.4.4.tar.gz

have you reported it?

I can go one better and file a PR, tbh. It's a one-liner.

https://github.com/luarocks/luarocks-site/blob/b8ade0ddf390eb40631f91d57ecf4f35595858d9/nginx.conf#L102

luarocks/luarocks-site#131

ilovezfs · 2018-03-23T01:43:46Z

What was the problem?

DomT4 · 2018-03-23T01:46:29Z

What was the problem?

A variation of:

The same s.gsub! "@LUA_PREFIX@", prefix will probably work.`

was indeed required as you suggested months ago, but there was also an issue where upstream apparently tweaked the header detection logic in a way that doesn't work with Homebrew's directory structure here, and that header silliness lead me down a ridiculous rabbit hole. In combination they work fine.

DomT4 · 2018-03-23T01:49:20Z

It became obvious enough when I dropped into the debug shell for extended periods and just ran build after build after build with slight tweaks each time, but outside the debug shell a lot of the helpful messages are hidden by brew and you just get that simple failure message. Shouldn't have taken me this long to fix it really, but time away leads to fresh thinking or some garbage like that.

ilovezfs · 2018-03-23T01:49:29Z

Formula/lua@5.1.rb

  end

  def install
    # Use our CC/CFLAGS to compile.
    inreplace "src/Makefile" do |s|
+      s.gsub! HOMEBREW_PREFIX, prefix


Does this actually work for a non-standard prefix?

Should do, theoretically. It is just a slight variation of what we've been doing in the lua formula for ages, without anyone complaining about it.

How does the replacement not fail if the prefix isn't in the file?

Why wouldn't the prefix be in the file? We're the ones adding that line in the inline patch. Maybe I'm misunderstanding you? I've slept for about 4 hours over the last day 🙃.

Ah, OK. That's what I get for looking at this on my iPhone.

+ $(CC) -dynamiclib -install_name HOMEBREW_PREFIX/lib/liblua.5.1.dylib \ + -compatibility_version 5.1 -current_version 5.1.5 \ + -o liblua.5.1.5.dylib $^

compared to:

+ $(CC) -dynamiclib -install_name @LUA_PREFIX@/lib/liblua.5.3.dylib \ + -compatibility_version 5.3 -current_version 5.3.4 \ + -o liblua.5.3.4.dylib $^

in the lua formula. Same principle, just a slight divergence at some point for some reason. Possibly my fault given how much I've touched these formulae over the years.

This does not look right. If I am not mistaking, this should be

s.gsub! "HOMEBREW_PREFIX", prefix

Don't think so? brew unpack --patch lua@5.1 shows the blob as I expected it to be:

$(LUA_A): $(CORE_O) $(LIB_O) $(CC) -dynamiclib -install_name /usr/local/lib/liblua.5.1.dylib \ -compatibility_version 5.1 -current_version 5.1.5 \ -o liblua.5.1.5.dylib $^

I get this for non-standard homebrew prefix.

brew upgrade lua@5.1 ==> Upgrading 1 outdated package, with result: lua@5.1 5.1.5_6 ==> Upgrading lua@5.1 ==> Downloading https://www.lua.org/ftp/lua-5.1.5.tar.gz ######################################################################## 100.0% Error: inreplace failed src/Makefile: expected replacement of #<Pathname:/home/comp/chengxu/usr> with #<Pathname:/home/comp/chengxu/usr/Cellar/lua@5.1/5.1.5_6>

I'm pretty sure I tried a string replacement in the default prefix and hit issues with it, which is why I didn't go down that route. Maybe we should just save ourselves some hassle & change it to @LUA_PREFIX@ to match the lua formula.

DomT4 · 2018-03-23T02:01:00Z

Would ya look at that. A green CI build. Thought I'd never see the day here at times 🤦‍♂️.

ilovezfs · 2018-03-23T02:01:31Z

Formula/lua.rb

-          s.gsub! lib.to_s, "#{HOMEBREW_PREFIX}/lib"
-          s.gsub! bin.to_s, "#{HOMEBREW_PREFIX}/bin"
+          s.gsub! libexec, opt_libexec
+          s.gsub! include, "#{HOMEBREW_PREFIX}/include"


Maybe HOMEBREW_PREFIX/"include"

DomT4 · 2018-03-23T09:52:05Z

Upstream merged the PR so the redirect is HTTPS to HTTPS now, which is fine, so I'll push new commits to use the official URL and after that I think we're alright here if you're happy.

Resource: luarocks
==> Downloading https://luarocks.org/releases/luarocks-2.4.4.tar.gz
==> Downloading from https://luarocks.github.io/luarocks/releases/luarocks-2.4.4.tar.gz
/usr/bin/curl --show-error --user-agent Homebrew/1.5.12-9-g49927ed (Macintosh; Intel Mac OS X 10.13.4) curl/7.54.0 --fail --location --remote-time --continue-at - --output /usr/local/var/homebrewcache/lua--luarocks-2.4.4.tar.gz.incomplete https://luarocks.github.io/luarocks/releases/luarocks-2.4.4.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  137k  100  137k    0     0  79313      0  0:00:01  0:00:01 --:--:-- 79306
Downloaded to: /usr/local/var/homebrewcache/lua--luarocks-2.4.4.tar.gz
SHA256: 3938df33de33752ff2c526e604410af3dceb4b7ff06a770bc4a240de80a1f934

Closes #25597.

ilovezfs · 2018-03-23T13:40:41Z

Shipped! Thanks @DomT4

DomT4 · 2018-03-23T16:40:52Z

Thanks Joe. Nice to be able to finally delete this branch, heh.

ilovezfs · 2018-03-23T17:31:12Z

Or just hoard branches as I do!

DomT4 · 2018-03-23T18:28:03Z

That would be the death of what’s left of my sanity.

DomT4 mentioned this pull request Dec 2, 2017

Configure script incorrectly assumes ncursesw is present if termkey is present? martanne/vis#636

Closed

ilovezfs added the do not merge label Dec 2, 2017

This was referenced Dec 3, 2017

lua: update luarocks to 2.4.3 #21296

Closed

lua@5.3: revision bump to fix dylib & pc versioning #21297

Closed

ilovezfs suggested changes Dec 3, 2017

View reviewed changes

DomT4 changed the title ~~Lua family: update Luarocks to 2.4.1~~ Lua@5.1/Lua@5.3: update Luarocks to 2.4.1 (WIP) Dec 3, 2017

DomT4 changed the title ~~Lua@5.1/Lua@5.3: update Luarocks to 2.4.1 (WIP)~~ Lua@5.1/Lua@5.3: update Luarocks to 2.4.3 (WIP) Dec 3, 2017

stale bot removed the stale No recent activity label Feb 14, 2018

stale bot added the stale No recent activity label Mar 7, 2018

stale bot removed the stale No recent activity label Mar 7, 2018

DomT4 changed the title ~~Lua@5.1/Lua@5.3: update Luarocks to 2.4.3 (WIP)~~ lua@5.1: update luarocks to 2.4.3 (WIP) Mar 8, 2018

mistydemeo mentioned this pull request Mar 21, 2018

luarocks-5.1 requires /usr/local writable, but this is not possible #25597

Closed

DomT4 changed the title ~~lua@5.1: update luarocks to 2.4.3 (WIP)~~ lua@5.1 & lua: update luarocks to 2.4.4 Mar 23, 2018

ilovezfs reviewed Mar 23, 2018

View reviewed changes

DomT4 added 2 commits March 23, 2018 09:52

lua@5.1: update luarocks to 2.4.4

a74ecd1

Closes #25597.

lua: update luarocks to 2.4.4

2fa4fc9

ilovezfs removed the do not merge label Mar 23, 2018

ilovezfs approved these changes Mar 23, 2018

View reviewed changes

ilovezfs closed this in cec8a2b Mar 23, 2018

DomT4 deleted the luarocks_sigh branch March 23, 2018 16:40

Homebrew locked and limited conversation to collaborators May 4, 2018

lua@5.1 & lua: update luarocks to 2.4.4 #21282

lua@5.1 & lua: update luarocks to 2.4.4 #21282

Conversation

DomT4 commented Dec 2, 2017 • edited

DomT4 commented Dec 2, 2017

DomT4 commented Dec 3, 2017 • edited

DomT4 commented Dec 3, 2017

DomT4 commented Dec 3, 2017

ilovezfs commented Dec 3, 2017

DomT4 commented Dec 3, 2017

DomT4 commented Dec 3, 2017

ilovezfs commented Dec 3, 2017

DomT4 commented Dec 3, 2017

ilovezfs commented Dec 3, 2017

ilovezfs commented Dec 3, 2017 • edited

DomT4 commented Dec 3, 2017

ilovezfs left a comment

Choose a reason for hiding this comment

ilovezfs commented Dec 3, 2017

DomT4 commented Dec 3, 2017

ilovezfs commented Dec 3, 2017

DomT4 commented Dec 3, 2017

DomT4 commented Dec 3, 2017

ilovezfs commented Dec 3, 2017

DomT4 commented Dec 3, 2017

ilovezfs commented Dec 3, 2017

DomT4 commented Dec 3, 2017

ilovezfs commented Dec 3, 2017

DomT4 commented Dec 3, 2017

stale bot commented Mar 7, 2018

DomT4 commented Mar 7, 2018

DomT4 commented Mar 8, 2018

DomT4 commented Mar 23, 2018

DomT4 commented Mar 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilovezfs commented Mar 23, 2018

DomT4 commented Mar 23, 2018

DomT4 commented Mar 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DomT4 commented Mar 23, 2018

Choose a reason for hiding this comment

DomT4 commented Mar 23, 2018

ilovezfs commented Mar 23, 2018

DomT4 commented Mar 23, 2018

ilovezfs commented Mar 23, 2018

DomT4 commented Mar 23, 2018

DomT4 commented Dec 2, 2017 •

edited

DomT4 commented Dec 3, 2017 •

edited

ilovezfs commented Dec 3, 2017 •

edited