zig 0.1.1 (new formula) #23189

jfo · 2018-01-23T10:20:14Z

HI! Thanks for brew.

I'd like to add zig's 0.1.1 release to brew. I do need feedback on a dependency issue, though.

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

~ $ brew audit --strict zig
zig:
  * Dependency 'llvm@5' is an alias; use the canonical name 'llvm'.
Error: 1 problem in 1 formula

See: ziglang/zig#714 (comment)

Please lmkwyt! Thank you.

This PR resolves ziglang/zig#714

fxcoudert · 2018-01-23T10:23:48Z

Formula/zig.rb

+
+  def install
+    Dir.mkdir "build"
+    Dir.chdir "build" do


On a single line: mkdir "build" do

fxcoudert · 2018-01-23T10:24:49Z

Formula/zig.rb

+  def install
+    Dir.mkdir "build"
+    Dir.chdir "build" do
+      system "cmake", "..",


Probably you can simply say: system "cmake", "..", *std_cmake_args which should take care of the paths for you

I get Error: Empty installation when I use that.

std_cmake_args contains:

-DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX=#{prefix} -DCMAKE_BUILD_TYPE=Release -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev

But I do not understand what your CMAKE_PREFIX_PATH is pointing to. #{prefix} will expand to zig's own prefix (e.g. /usr/local/Cellar/zig/0.1.1), so why are you appending llvm@5 to that?

Actually maybe I'm calling mkdir strangely, let me test a bit.

edit: I was. Was trying to call Dir.mkdir instead of mkdir.

I was naively following zig's build instructions to see how everything worked. std_cmake_args works great though!

fxcoudert · 2018-01-23T10:25:53Z

Formula/zig.rb

+  end
+
+  test do
+    src = <<-HEREDOC


We prefer the following syntax: (testpath/"hello.zip").write <<~EOS

fxcoudert · 2018-01-23T10:26:48Z

Formula/zig.rb

+    HEREDOC
+    File.write("hello.zig", src)
+    system "#{bin}/zig", "build-exe", "hello.zig"
+    system "./hello"


Can you check that the output from hello is as expected?
assert_equal "Hello, world!\n", shell_output("./hello")

Yes, that's much better thanks.

fxcoudert · 2018-01-23T11:03:56Z

Formula/zig.rb

+  end
+
+  test do
+    (testpath/"hello.zig").write <<~HEREDOC


We'll prefer EOS to HEREDOC, for consistency with other formulas.
And can the empty lines in hello.zig be removed?

til https://infinum.co/the-capsized-eight/multiline-strings-ruby-2-3-0-the-squiggly-heredoc

fxcoudert · 2018-01-23T11:05:30Z

Regarding llvm@5, our policy is to depend on llvm: when version 6 is published, hopefully there will be a new zig version to match it. Otherwise, if there is incompatibility, we will then modify the formula to depend on llvm@5.

jfo · 2018-01-23T11:29:30Z

Thanks for the reviews.

I am curious as to whether llvm is a build time dependency only. I'm waiting on an answer to that just so I'm sure. If it's necessary to have it during runtime, is it as simple as removing the :build symbol?

jfo · 2018-01-23T12:22:23Z

also the test is still failing with just llvm, despite passing brew audit --strict zig

Failing with same error as brew audit --new-formula zig does locally:

zig:
  * Dependency 'llvm' may be unnecessary as it is provided by macOS; try to build this formula without it.
Error: 1 problem in 1 formula

fxcoudert · 2018-01-23T13:24:51Z

That remaining audit failure we'll ignore, as it has a valid reason to use Homebrew LLVM.

fxcoudert · 2018-01-23T14:29:11Z

Formula/zig.rb

+  sha256 "a160d14aecebead2f8c574b0dd687cdfecc53d149d521a17b89b629d8b558c94"
+
+  depends_on "cmake" => :build
+  depends_on "llvm" => :build


zig links to LLVM's libc++ (/usr/local/opt/llvm/lib/libc++.1.dylib). So this dependency is necessary at runtime too. Remove the => :build.

Done, thanks for sussing that out!

jfo · 2018-01-23T17:18:43Z

@fxcoudert thanks a lot for a painless contributor experience and for the prompt reviews! I'll look forward to seeing this land.

I'll do some research around what fleshing out this formula might look like (see associated man issue) and whether or not that is necessary at all. At the very least we'll keep it bumped on new releases.

fxcoudert · 2018-01-23T17:57:32Z

hi @jfo why did you close this?

jfo · 2018-01-23T17:59:44Z

@fxcoudert sorry, I was pushing https://github.com/jfo/homebrew-core/commit/35218e954e19d44d2b6b35f8d221dc15a64425ad from a local branch and typed git push myremote master instead of git push myremote mybranch:master

jfo · 2018-01-23T18:00:27Z

I pushed my changes back to my fork's master but github is confused now.

edit: looks like reopening it triggered a recheck, sorry for the noise!! :)

ilovezfs · 2018-01-23T18:41:54Z

Formula/zig.rb

+
+  def install
+    mkdir "build" do
+      system "cmake", "..", *std_cmake_args


let's make this an in-tree build

do you mean

diff --git a/Formula/zig.rb b/Formula/zig.rb index 42ce4f54..758d9617 100644 --- a/Formula/zig.rb +++ b/Formula/zig.rb @@ -8,10 +8,8 @@ class Zig < Formula depends_on "llvm" def install - mkdir "build" do - system "cmake", "..", *std_cmake_args - system "make", "install" - end + system "cmake", ".", *std_cmake_args + system "make", "install" end test do

fxcoudert · 2018-01-23T20:12:23Z

@jfo thanks for your contribution to Homebrew!

fxcoudert · 2018-01-23T20:20:40Z

@BrewTestBot test this please

fxcoudert · 2018-01-23T20:40:13Z

@jfo sorry, somehow the <<-EOS.undent in one of the commits is making our build bot fail. Could you squash the 3 commits together into a single commit please? Then I can merge this.

fxcoudert · 2018-01-23T21:32:42Z

And… finally, it's in! Thanks again @jfo

jfo · 2018-01-23T21:33:44Z

🙌 thank you!

Super great and much appreciated.

fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Jan 23, 2018

jfo mentioned this pull request Jan 23, 2018

man page? ziglang/zig#715

Open

fxcoudert reviewed Jan 23, 2018

View reviewed changes

fxcoudert added the almost there PR is nearly ready to merge label Jan 23, 2018

fxcoudert added ready to merge PR can be merged once CI is green and removed almost there PR is nearly ready to merge labels Jan 23, 2018

jfo mentioned this pull request Jan 23, 2018

Add 0.1.1 to homebrew ziglang/zig#714

Closed

fxcoudert requested changes Jan 23, 2018

View reviewed changes

fxcoudert removed the ready to merge PR can be merged once CI is green label Jan 23, 2018

fxcoudert approved these changes Jan 23, 2018

View reviewed changes

fxcoudert added the ready to merge PR can be merged once CI is green label Jan 23, 2018

jfo closed this Jan 23, 2018

jfo reopened this Jan 23, 2018

ilovezfs reviewed Jan 23, 2018

View reviewed changes

ilovezfs approved these changes Jan 23, 2018

View reviewed changes

zig 0.1.1 (new formula)

62d62c0

fxcoudert closed this in c33c622 Jan 23, 2018

Homebrew locked and limited conversation to collaborators May 4, 2018

zig 0.1.1 (new formula) #23189

zig 0.1.1 (new formula) #23189

jfo commented Jan 23, 2018 •

edited

fxcoudert Jan 23, 2018

fxcoudert Jan 23, 2018

jfo Jan 23, 2018

fxcoudert Jan 23, 2018

jfo Jan 23, 2018 •

edited

jfo Jan 23, 2018

fxcoudert Jan 23, 2018

fxcoudert Jan 23, 2018

jfo Jan 23, 2018

fxcoudert Jan 23, 2018

jfo Jan 23, 2018

jfo Jan 23, 2018

fxcoudert commented Jan 23, 2018

jfo commented Jan 23, 2018

jfo commented Jan 23, 2018 •

edited

fxcoudert commented Jan 23, 2018

fxcoudert Jan 23, 2018

jfo Jan 23, 2018

jfo commented Jan 23, 2018 •

edited

fxcoudert commented Jan 23, 2018

jfo commented Jan 23, 2018

jfo commented Jan 23, 2018 •

edited

ilovezfs Jan 23, 2018

jfo Jan 23, 2018

ilovezfs Jan 23, 2018

fxcoudert commented Jan 23, 2018

fxcoudert commented Jan 23, 2018

fxcoudert commented Jan 23, 2018

fxcoudert commented Jan 23, 2018

jfo commented Jan 23, 2018

zig 0.1.1 (new formula) #23189

zig 0.1.1 (new formula) #23189

Conversation

jfo commented Jan 23, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfo Jan 23, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fxcoudert commented Jan 23, 2018

jfo commented Jan 23, 2018

jfo commented Jan 23, 2018 • edited

fxcoudert commented Jan 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfo commented Jan 23, 2018 • edited

fxcoudert commented Jan 23, 2018

jfo commented Jan 23, 2018

jfo commented Jan 23, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fxcoudert commented Jan 23, 2018

fxcoudert commented Jan 23, 2018

fxcoudert commented Jan 23, 2018

fxcoudert commented Jan 23, 2018

jfo commented Jan 23, 2018

jfo commented Jan 23, 2018 •

edited

jfo Jan 23, 2018 •

edited

jfo commented Jan 23, 2018 •

edited

jfo commented Jan 23, 2018 •

edited

jfo commented Jan 23, 2018 •

edited