kubernetes-cli 1.3.0 (stable), 1.4.0-alpha.0 (devel) #2731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,7 @@ def install | |||
|
|
|||
| dir = "_output/local/bin/darwin/#{arch}" | |||
| bin.install "#{dir}/kubectl" | |||
| bash_completion.install "contrib/completions/bash/kubectl" | |||
| (bash_completion/"kubectl").write `#{bin}/kubectl completion bash` | |||
There was a problem hiding this comment.
kubectl v1.3.0 does not support the completion subcommand as far as I know, so I would avoid doing that before v1.4.0 becomes the new stable
There was a problem hiding this comment.
I believe completion subcommand was implemenented in v1.3.0-alpha5. I confirmed completion works in v1.3.0 (stable) and 1.4.0-alpha.0 (devel).
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG.md/#v130-alpha5
There was a problem hiding this comment.
My bad, I missed that commit. Thanks a lot for adding this! 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install <formula>(where<formula>is the name of the formula you're submitting)?brew audit --strict --online <formula>(after doingbrew install <formula>)?There is the open issue #1676 but it seems to be neglected and not latest version.