Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-cli 1.3.0 (stable), 1.4.0-alpha.0 (devel) #2731

Closed
wants to merge 1 commit into from
Closed

kubernetes-cli 1.3.0 (stable), 1.4.0-alpha.0 (devel) #2731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions Formula/kubernetes-cli.rb
View file
Open in desktop
Expand Up @@ -4,8 +4,8 @@ class KubernetesCli < Formula
head "https://github.com/kubernetes/kubernetes.git"

stable do
url "https://github.com/kubernetes/kubernetes/archive/v1.2.4.tar.gz"
sha256 "20a3984f9c044f1a1da3088166b181f3c10380d3efd4bf3fbc64678fef279ced"
url "https://github.com/kubernetes/kubernetes/archive/v1.3.0.tar.gz"
sha256 "77fbc5db607daa723e7b6576644d25e98924439954523808cf7ad2c992566398"
end

bottle do
Expand All @@ -16,9 +16,9 @@ class KubernetesCli < Formula
end

devel do
url "https://github.com/kubernetes/kubernetes/archive/v1.3.0-alpha.4.tar.gz"
sha256 "3cff9661b94c138149721e8f57411e89690afef97bcdb515092ca3acf8705900"
version "1.3.0-alpha.4"
url "https://github.com/kubernetes/kubernetes/archive/v1.4.0-alpha.0.tar.gz"
sha256 "7530fabf418fccf7bef08281efa9a51d86921726c8efac4f0e63ba1e87d83482"
version "1.4.0-alpha.0"
end

depends_on "go" => :build
Expand All @@ -30,7 +30,7 @@ def install

dir = "_output/local/bin/darwin/#{arch}"
bin.install "#{dir}/kubectl"
bash_completion.install "contrib/completions/bash/kubectl"
(bash_completion/"kubectl").write `#{bin}/kubectl completion bash`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl v1.3.0 does not support the completion subcommand as far as I know, so I would avoid doing that before v1.4.0 becomes the new stable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe completion subcommand was implemenented in v1.3.0-alpha5. I confirmed completion works in v1.3.0 (stable) and 1.4.0-alpha.0 (devel).

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG.md/#v130-alpha5

  • Move shell completion generation into 'kubectl completion' command (#23801, @sttts)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I missed that commit. Thanks a lot for adding this! 👍

end

test do
Expand Down