geogram 1.6.6 (new formula) #31094
geogram 1.6.6 (new formula) #31094
Conversation
Formula/geogram.rb
Outdated
| homepage "http://alice.loria.fr/software/geogram/doc/html/index.html" | ||
| url "https://gforge.inria.fr/frs/download.php/file/37635/geogram_1.6.6.tar.gz" | ||
| sha256 "08211b1d6f21e14701e3fd5c79adbe331cdf66b8af84efdb54cd7048244691b5" | ||
| depends_on "cmake" => :build |
There was a problem hiding this comment.
Should be an empty line between sha256 and the first depends_on.
Formula/geogram.rb
Outdated
| # don't write directly into /usr/local/lib/cmake/modules | ||
| inreplace "CMakeLists.txt", "lib/cmake/modules", "#{share}/cmake/Modules" | ||
| # workaround for undefined _mm_set_pd1 in clang | ||
| inreplace "src/lib/geogram/numerics/predicates.cpp", "_mm_set_pd1", "_mm_set1_pd" |
There was a problem hiding this comment.
This is something we're going to need upstream to handle, rather than fixing it ourselves.
There was a problem hiding this comment.
Do I only need to try to get upstream to handle the _mm_set_pd1 issue, or to also make the CMake module location configure-time configurable?
There was a problem hiding this comment.
Both would be nice 😸, but the _mm_set_pd1 issue is the one I was referencing here.
There was a problem hiding this comment.
The _mm_set_pd1 issue should be fixed upstream in the next release: https://lists.gforge.inria.fr/pipermail/geogram-users/2018-August/000158.html
Formula/geogram.rb
Outdated
| f << "\nset(CMAKE_INSTALL_PREFIX #{prefix})\n" | ||
| end | ||
| system "sh", "-f", "configure.sh" | ||
| Dir.chdir("build/Darwin-clang-dynamic-Release") |
There was a problem hiding this comment.
cd do is the preferred syntax in core.
Formula/geogram.rb
Outdated
| end | ||
|
|
||
| test do | ||
| system "curl", "https://raw.githubusercontent.com/FreeCAD/Examples/master/Point_cloud_ExampleFiles/PointCloud-Data_Stanford-Bunny.asc", "-o", "bunny.xyz" |
There was a problem hiding this comment.
Use a resource do block in the main body and then stage this in test do that way. It'll need to be pinned to a commit though, not simply fetching master.
There was a problem hiding this comment.
I've made a change for this - I'm not sure if there's a more idiomatic way than File.rename inside a resource stage block to handle the URL filename differing from the needed filename (the test needs the .xyz extension instead of .asc).
Formula/geogram.rb
Outdated
| inreplace "CMakeLists.txt", "lib/cmake/modules", "#{share}/cmake/Modules" | ||
| # workaround for undefined _mm_set_pd1 in clang | ||
| inreplace "src/lib/geogram/numerics/predicates.cpp", "_mm_set_pd1", "_mm_set1_pd" | ||
| open("CMakeOptions.txt", "a") do |f| |
There was a problem hiding this comment.
Should be able to use (buildpath/"CMakeOptions.txt").append_lines "blah" or the <<~EOS format of that same helper here.
Formula/geogram.rb
Outdated
|
|
||
| test do | ||
| resource("bunny").stage do | ||
| File.rename("PointCloud-Data_Stanford-Bunny.asc", "bunny.xyz") |
There was a problem hiding this comment.
I'd probably do:
testpath.install resource("bunny")
mv "PointCloud-Data_Stanford-Bunny.asc", "bunny.xyz"
system "#{bin}/vorpalite", "profile=reconstruct", "bunny.xyz", "bunny.meshb"
assert_predicate testpath/"bunny.meshb", :exist?, "bunny.meshb should exist!"or something.
|
Thanks for the great feedback, I've re-pushed with those changes! |
This adds Geogram, a programming library of geometric algorithms. This is a dependency for programs such as AliceVision / Meshroom (https://alicevision.github.io/).
This adds Geogram, a programming library of geometric algorithms. This
is a dependency for programs such as AliceVision / Meshroom
(https://alicevision.github.io/).
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?