Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: --with-drafts option was removed, used by developers #32598

Closed
wants to merge 1 commit into from
Closed

problem: --with-drafts option was removed, used by developers #32598

wants to merge 1 commit into from

Conversation

wesyoung
Copy link
Contributor

@wesyoung wesyoung commented Oct 1, 2018

solution: re-add it back in

ref:

#12207
https://github.com/Linuxbrew/homebrew-core/commit/1bbcc56c961b881cdcaf00cfce8407779538c781#commitcomment-30702803

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@SMillerDev
Copy link
Member

Upstream has it disabled by default and the issue you linked says nobody uses it. I don't really see a need to add back this potentially silently failing option. (especially when making a tap is so easy)

@fxcoudert
Copy link
Member

Our analytics show that this option was never used:

install events in the last 90 days
================================================================================
1 | zyre                                                          | 17 |  73.91%
2 | zyre --HEAD                                                   |  6 |  26.09%
================================================================================
Total                                                             | 23 |    100%
================================================================================

We don't have enough CI power to test options, and they tend to break over time and add to our maintenance burned (see open issues for many examples of that). Especially for formulas with low install counts (7 installs a month for zyre)…

Thus, closing.

@fxcoudert fxcoudert closed this Oct 1, 2018
@wesyoung
Copy link
Contributor Author

wesyoung commented Oct 1, 2018

i guess i didn't understand those requirements for a contribution, thanks for the explanation. zyre is an odd bird at the moment, we're (the upstream devs) testing some draft crypto stuff that takes time (i myself only re-install it like that maybe every few months when the bits have had a chance to run for a while). brew just made that a bit easier todo and since it's been a great project (brew), trying contribute back that context and expertise (in relation to the zeromq community) back to brew. :)

i get the "CI overhead" argument, gatta do what you gatta do. i'll look into taps.. thx.

@lock lock bot added the outdated PR was locked due to age label Oct 31, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants