Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftlint 0.28.2 #34268

Closed
wants to merge 5 commits into from
Closed

swiftlint 0.28.2 #34268

wants to merge 5 commits into from

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Nov 18, 2018

Created with brew bump-formula-pr.

@jpsim jpsim mentioned this pull request Nov 18, 2018
@jpsim
Copy link
Contributor Author

jpsim commented Nov 19, 2018

This appears to have the same failure on Mojave as #34049. I don't know what that failure means, so I'd appreciate any help from maintainers to address this.

@norio-nomura
Copy link
Contributor

I opened realm/SwiftLint#2473 that can be used for avoiding the issue.

@jpsim
Copy link
Contributor Author

jpsim commented Nov 22, 2018

Thanks! Updated the hash here to hopefully resolve.

@norio-nomura
Copy link
Contributor

Oops! Sorry, I didn't explain that It needs to set SWIFTLINT_DISABLE_SOURCEKIT=1 on executing test for using realm/SwiftLint#2473.

@jpsim
Copy link
Contributor Author

jpsim commented Nov 22, 2018

Ah yes of course. Updated.

@javian
Copy link
Contributor

javian commented Nov 22, 2018

It currently fails saying

10:10:33   RuntimeError: 0.28.1 tag should be b458e20f2720a52f69a1d45ffebf45ac264ed20e
10:10:33 but is actually 4955c173a097b6b0dc49c495b462112da09ed099

@norio-nomura
Copy link
Contributor

It seems to need new tag 0.28.2 or force move 0.28.1.

@javian
Copy link
Contributor

javian commented Nov 24, 2018

We can only do stable releases so it would have to be 0.28.1 since .2 isn't released yet.

@jpsim jpsim changed the title swiftlint 0.28.1 swiftlint 0.28.2 Nov 24, 2018
@jpsim
Copy link
Contributor Author

jpsim commented Nov 24, 2018

Just released 0.28.2 https://github.com/realm/SwiftLint/releases/tag/0.28.2

@javian
Copy link
Contributor

javian commented Nov 25, 2018

Thanks @jpsim !

@javian javian closed this in 35a800b Nov 25, 2018
@lock lock bot added the outdated PR was locked due to age label Dec 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants