Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 7.3.0 #34869

Closed
wants to merge 1 commit into from
Closed

php 7.3.0 #34869

wants to merge 1 commit into from

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot
Copy link
Member

  • New formulae should not have a bottle do block

@fxcoudert
Copy link
Member

fxcoudert commented Dec 7, 2018

php@7.2 failed to build:

==> make install
Installing PHP SAPI module:       apache2handler
Installing PHP CLI binary:        /usr/local/Cellar/php@7.2/7.2.13/bin/
mkdir: /usr/local/Cellar/php@7.2/7.2.13/bin: File exists
Installing shared extensions:     /usr/local/Cellar/php@7.2/7.2.13/lib/php/20170718/
Possible unintended interpolation of @7 in string at (eval 26) line 1.
/usr/local/opt/httpd/lib/httpd/build/instdso.sh SH_LIBTOOL='/usr/local/opt/apr/libexec/build-1/libtool' libs/libphp7.so /usr/local/Cellar/php.2/7.2.13/lib/httpd/modules
Installing PHP CLI man page:      /usr/local/Cellar/php@7.2/7.2.13/share/man/man1/
/usr/local/opt/apr/libexec/build-1/libtool --mode=install install libs/libphp7.so /usr/local/Cellar/php.2/7.2.13/lib/httpd/modules/
Installing PHP FPM binary:        /usr/local/Cellar/php@7.2/7.2.13/sbin/
libtool: install: install libs/libphp7.so /usr/local/Cellar/php.2/7.2.13/lib/httpd/modules
install: /usr/local/Cellar/php.2/7.2.13/lib/httpd/modules: No such file or directory
apxs:Error: Command failed with rc=4653056
.
make: *** [install-sapi] Error 1

The string /usr/local/Cellar/php@7.2 leads to Possible unintended interpolation of @7 in string, which turns it into /usr/local/Cellar/php.2, which of course fails. The php@7.1 formula works around this issue (line 65 of php@7.1.rb).


Also:

php@7.2:
  * Versioned formulae should use `keg_only :versioned_formula`

@SMillerDev
Copy link
Member Author

You'd think I'd be able to write a formula by now...

@fxcoudert fxcoudert closed this in be6ad0d Dec 7, 2018
@fxcoudert fxcoudert mentioned this pull request Dec 7, 2018
4 tasks
@lock lock bot added the outdated PR was locked due to age label Jan 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 6, 2019
@SMillerDev SMillerDev deleted the php-7.3.0 branch January 10, 2019 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants