Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.11.5 #36344

Closed
wants to merge 3 commits into from
Closed

Go 1.11.5 #36344

wants to merge 3 commits into from

Conversation

leonklingele
Copy link
Contributor

@leonklingele leonklingele commented Jan 23, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@leonklingele
Copy link
Contributor Author

Error: An exception occurred within a child process:
  Errno::ENOENT: No such file or directory @ dir_chdir - src

Is this because I'm still on 10.11.6?

$ brew config | head -n3
HOMEBREW_VERSION: 1.9.2-91-gb221a46
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: b221a46af2db8c99606af176c2c4fd10e072ccfb

@leonklingele
Copy link
Contributor Author

After some debugging I found the reason: the new release tarball includes two garbage folders: gocache and tmp which screw up the build process, but I don't know why and how to fix it.

@leonklingele
Copy link
Contributor Author

I don't know Ruby, but this seems to do the trick: 715ee1c

@tonyghita
Copy link

Some details on the extra directories: https://groups.google.com/d/msg/golang-announce/mVeX35iXuSw/HxYXaBnYEAAJ

@wingyplus
Copy link
Contributor

Should we waiting for golang/go#29906?

@leonklingele
Copy link
Contributor Author

@wingyplus no, they "will not be updating the tarballs for this release". See golang/go#29906 (comment).

@fxcoudert
Copy link
Member

@leonklingele the comment you linked to also says:

Only go1.11.5.linux-amd64.tar.gz and go1.10.8.linux-amd64.tar.gz are affected.

Which is clearly not the case.

@leonklingele
Copy link
Contributor Author

@fxcoudert this is a security release and should be merged asap. If they decide to create a new release without the temp directories, we can simply remove the workaround.

@tsuna
Copy link
Contributor

tsuna commented Jan 25, 2019

Please merge this ASAP, thanks :)

@fxcoudert fxcoudert closed this in ffb004e Jan 25, 2019
@lock lock bot added the outdated PR was locked due to age label Feb 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants