gst-plugins-bad - Missing dependencies for WebRTCBin

[vinicius-tona]

LibNice and SRTP are required to build WebRTCBin

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[fxcoudert]

libnice is a heavy dependency, because it brings gnutls. Not sure how many users this will benefit.

[vinicius-tona]

@fxcoudert How about adding it as optional?
But we need to make sure it will be kept on further changes because if we check the history we can see this dependency always being added and removed. Probably because brew audit --strict says that Formulae should not have optional or recommended dependencies.

Also, I don't see an issue on adding this dependency considering that webrtcbin is part of gst-plugins-bad. I find it inconsistent and always require debugging (even to realize that you need to add a -with-libnice). But that's only my opinion.

[SMillerDev]

Options have been removed from homebrew core last year because they simply break way too often.

[vinicius-tona]

Ok sorry, I didn't know that.

Do we add libnice since webrtcbin is part of gst-plugins-bad? Do we keep it inconsistent? Is there another approach I'm not aware of?

Regards

[nirbheek]

Speaking as a gstreamer developer, webrtc support is important and is used by a large number of people. I would highly recommend enabling it by default. All Linux distros ship it, for instance.

[SMillerDev]

If it benefits a lot of users let's just include it as a default

[vinicius-tona]

@SMillerDev
My PR is including it as default, is there anything else I need to do before merging it?

[jonchang]

Please bump the revision so users will get the new build on brew upgrade.

[fxcoudert]

Please bump the revision so users will get the new build on brew upgrade

And squash everything into a single commit, with message gst-plugins-bad: add WebRTCBin

[vinicius-tona]

@fxcoudert Done, thanks for letting me know

[fxcoudert]

Thanks @vinicius-tona you rock!