Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squashfs: add zstd support #43253

Closed
wants to merge 1 commit into from
Closed

Conversation

razum2um
Copy link

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Please merge this PR first Homebrew/formula-patches#277
After that I'll update patch url to proper one

See working tap here: https://github.com/lunatic-cat/homebrew-tap

@javian
Copy link
Contributor

javian commented Aug 20, 2019

It seems that the maintainer is working on this git repo https://github.com/plougher/squashfs-tools/ which includes zstd support . Could you check if there's a release available or if one is planned ?

@razum2um
Copy link
Author

razum2um commented Aug 20, 2019

Frankly speaking, I just missed that repo, sorry

I see 3.* tags there, but that's not releases.
Link to the issue about next release: plougher/squashfs-tools#54

Also link to previous attempt to update this in brew #32818

@fxcoudert
Copy link
Member

fxcoudert commented Aug 26, 2019

We do not want to add patches for extra functionality, we only use patches for critical issues (build failure, security, major crash). We try to ship software as closely as released by upstream, as we cannot (and do not want to) become de facto maintainers for 4000+ software.

The existing tap is probably the best solution for now.

@fxcoudert fxcoudert closed this Aug 26, 2019
@blake-riley blake-riley mentioned this pull request Sep 3, 2019
5 tasks
@lock lock bot added the outdated PR was locked due to age label Jan 13, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants