Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: Make sure gobject-2.0.pc points to libffi's opt path #44446

Closed
wants to merge 2 commits into from
Closed

glib: Make sure gobject-2.0.pc points to libffi's opt path #44446

wants to merge 2 commits into from

Conversation

nox
Copy link
Contributor

@nox nox commented Sep 20, 2019 •
edited

Fixes #40179.

There is some precedent in other formulas to do that, either for libffi, or for gettext in glib's own formula.

@nox nox mentioned this pull request Sep 20, 2019
Closed
6 tasks
@nox
Copy link
Contributor Author

nox commented Sep 21, 2019

I can't reproduce the sofia-sip failure, and I don't see how my patch can even break it.

@nox nox mentioned this pull request Sep 22, 2019
Closed
6 tasks
@nox
Copy link
Contributor Author

nox commented Sep 22, 2019

This also fixes @jeroen's issue reported in #37873.

@jonchang
Copy link
Contributor

Try doing a revision bump for that formula, which I think should fix the symptom for now. It’s possible that an opportunistic link occurred when another formula was built. If you could fix that too that would be great, otherwise the revision increment should be sufficient.

@jonchang
Copy link
Contributor

I meant bumping the revision of sofia-sip. There should be no need to do two revision bumps of glib.

@nox
Copy link
Contributor Author

nox commented Sep 23, 2019

Oh, that makes more sense indeed. Done.

@nox
Copy link
Contributor Author

nox commented Sep 23, 2019

Build was aborted for some reason and it failed to clone the repo on Mojave for some reason anyway, force-pushed new commits for the CI to trigger itself again.

@nox
Copy link
Contributor Author

nox commented Sep 23, 2019

Those failures aren't related to anything I did, right @jonchang?

@jonchang
Copy link
Contributor

The build machines seem to be having disk space issues.

@jonchang jonchang closed this in 8bfbd00 Sep 24, 2019
@jonchang
Copy link
Contributor

Merged despite unrelated test failures (due to build VM issues). Thanks for your help in getting this fixed for everyone @nox!

nox added a commit to servo/servo that referenced this pull request Sep 24, 2019
@nox
Remove obsolete macOS build instructions
15e5bb7 
openssl is already installed through the Brewfile, and libffi needs no
environment variable anymore now that glib was fixed.

Homebrew/homebrew-core#44446
@nox nox mentioned this pull request Sep 24, 2019
Merged
@sdroege sdroege mentioned this pull request Sep 24, 2019
Closed
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 25, 2019
Auto merge of #24279 - servo:macos-build, r=jdm
57961bd 
Remove obsolete macOS build instructions

openssl is already installed through the Brewfile, and libffi needs no
environment variable anymore now that glib was fixed.

Homebrew/homebrew-core#44446

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24279)
<!-- Reviewable:end -->
@lock lock bot added the outdated PR was locked due to age label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libffi: libffi.pc link not installed in /usr/local
2 participants
@nox @jonchang