aspell: explicitly depend on ncurses

[idvorkin]

Required for linuxbrew, otherwise won't link to ncurses

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• [] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
  It works on linuxbrew, but on OSX it fails as follows - help on how to resolve would be awesome:

➜  Formula git:(master) brew audit --strict aspell                                                                            <<<
Traceback (most recent call last):
        2: from /Users/idvorkin/.gem/ruby/2.6.0/bin/bundle:23:in `<main>'
        1: from /usr/local/Cellar/ruby/2.6.3/lib/ruby/2.6.0/rubygems.rb:302:in `activate_bin_path'
/usr/local/Cellar/ruby/2.6.3/lib/ruby/2.6.0/rubygems.rb:283:in `find_spec_for_exe': Could not find 'bundler' (1.17.2) required by
your /usr/local/Homebrew/Library/Homebrew/Gemfile.lock. (Gem::GemNotFoundException)
To update to the latest version installed on your system, run `bundle update --bundler`.
To install the missing version, run `gem install bundler:1.17.2`
Error: failed to run `/Users/idvorkin/.gem/ruby/2.6.0/bin/bundle install`!

---

[Bo98]

You probably want uses_from_macos which is like depends_on but doesn't apply on macOS.

[idvorkin]

What's the guidance on when to use use_from_macos vs depends_on? In other projects I've used the guidance have same logic as broadly as possible.

…

On Sat, Dec 21, 2019 at 6:50 AM Bo Anderson ***@***.***> wrote: You probably want uses_from_macos which is like depends_on but doesn't apply on macOS. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#48163?email_source=notifications&email_token=AACETFJFN6FUZFQPBLB7QHDQZYULFA5CNFSM4J6HK3T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHO5NJY#issuecomment-568186535>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACETFIXEVLS4NHQ422E23TQZYULFANCNFSM4J6HK3TQ> .

[idvorkin]

Updated to use use_from_macos

[iMichka]

On the mac repo, we use use_from_macos. This is a no-op here. In theory the build bot would have told you so, but we did not have time/the manpower to write a test for this. So for now it's just a manual hint our maintainers need to tell you.

On mac we use the system ncurses (and most system libraries). On linux we need to depend on ncurses, as it is not provided by most systems.

[idvorkin]

Hymn, looks like the CI build didn't complete? Do I need to do something?

[iMichka]

It's queued. We had some long builds lately, so there is some delay in the tests right now.

[idvorkin]

Wow CI builds really are slow :)

The error looks like a transient network connectivity issue (I can download the file now) is there a way to kick off a second run?

From: https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/53907/version=catalina/testReport/junit/brew-test-bot/catalina/audit_aspell___online/

Error Message
failed: brew audit aspell --online
Stacktrace
        Error: 1 problem in 1 formula detected
aspell:
  * Stable resource "rw": The URL https://ftp.gnu.org/gnu/aspell/dict/rw/aspell-rw-0.50-0.tar.bz2 is not reachable