mmctl 0.2.1 (new formula)

[ethervoid]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[ethervoid]

@SMillerDev Requested changes done :)

[fxcoudert]

Sounds brand new, and not yet meeting our notability criteria.

[elyscape]

@ethervoid In case it would help any, I wrote a simpler formula that you can mine for ideas.

[ethervoid]

@fxcoudert this CLI tool has been in Mattermost for a long time.

We just move it to a new project outside the Mattermost server in order to have an independent client and its widely used by people working with Mattermost. It would be great to have an easy way to install it through a powerful tool like brew :)

[ethervoid]

@bayandin I've applied the required changes :)

[elyscape]

FWIW, it probably makes more sense to set make parameters in the call to make rather than as environment variables, with something like this:

ENV["GOBIN"] = buildpath/"bin"

hash = Utils.popen_read("git rev-parse HEAD").chomp
(buildpath/"src/github.com/mattermost/mmctl").install buildpath.children
cd "src/github.com/mattermost/mmctl" do
  system "make", "install", "ADVANCED_VET=FALSE", "BUILD_HASH=#{hash}", "BUILD_VERSION=#{version}"
end

[elyscape]

Furthermore, you don't need to set BUILD_HASH here because the makefile will generate the same result if you don't specify a value.

[ethervoid]

I'd rather prefer to pass them as environment variables instead of making a huge command because it's only calling one command so it's not going to create a problem there.

And I prefer to get the BUILD_HASH explicitly even though the Makefile does it, because the person that reads the code in the future knows where is being set and where that comes from.

[elyscape]

Installing shell completions would be nice. That can be done with the following snippet at the end of the install stanza:

# Install bash completion
output = Utils.popen_read("#{bin}/mmctl completion bash")
(bash_completion/"mmctl").write output

# Install zsh completion
output = Utils.popen_read("#{bin}/mmctl completion zsh")
(zsh_completion/"_mmctl").write output

[ethervoid]

@elyscape I don't like to install scripts in the users env without theire permission

[SMillerDev]

It doesn't install to the user environment, it installs to a separate bash completion directory.

[ethervoid]

@SMillerDev Yes, I know. What I mean is that I don't like to install more than the essential but if you think is good for the user and a best practice to have the Formulae in brew, I'll include the completion scripts installation

[SMillerDev]

I don't think there's an official best practice but I've never seen anyone complain about being able to source completions.

[ethervoid]

@SMillerDev In that case I'd rather prefer to add a new formulae called mmctl-completion like for example rails-completion, cargo-completion, etc

What else do I need to change to have this Formulae merged? Thank you!

[SMillerDev]

Those are all seperate projects, homebrew doesn't split projects unless there's no other way. Please just add the bash completion.

[ethervoid]

@SMillerDev changes done and checks passed

[SMillerDev]

Thanks @ethervoid

[chenrui333]

Thanks @ethervoid for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

[ethervoid]

@chenrui333 thank you very much! and thanks to all of you for working and maintaining this amazing tool :)

[chenrui333]

Appreciate the kind words!