ghc-8.10.1

[lukel97]

Extending #52093 @fishtreesugar

[fishtreesugar]

Thanks!

[lukel97]

I think we'll need to make a whitelist exception for ghc@8.8 here https://github.com/Homebrew/brew/blob/72f7ef3d02dce3eb9056493044fcc530d7a83d3f/Library/Homebrew/rubocops/urls.rb#L24-L44

[lukel97]

Should the CI be taking this long?

[Bo98]

GHC pull requests usually take 16-19 hours to build the two GHC formulae and go through and test building every GHC dependent (49 formulae).

[lukel97]

Holy smokes. Is there a way to run it locally? I’m not able to see the logs from GitHub Actions and I’m sure there’s bound to be some failures

[Bo98]

Is there a way to run it locally?

If you have a lot of time to spare, I guess you can do brew install -s ghc ghc@8.8 $(brew uses --recursive --include-build ghc) but you might as well wait on the CI.

I’m not able to see the logs from GitHub Actions

Logs can be seen when the CI run is complete.

[lukel97]

@Bo98 I've wrangled down most of the failures. Two of the failures are auditing failures, from cmt and mighttpd2.
Cmt's failure is that it's using a pre-release release on GitHub, but it's been using same version since the formula was initially added in January. mighttpd2 is failing because the website is unreachable (I've pinged the author).
I'm not sure if I'll be able to fix either of these within this PR, will it still be possible to merge this?

[lukel97]

I think the cmt auditing failure should be the only one left now, ready for review

[bayandin]

A patch for furmark doesn't apply:

==> Downloading https://github.com/diku-dk/futhark/commit/b862de37f1e2cd7e7b561b723d01da9c8d248881.diff?full_index=1
cp -p /Users/brew/Library/Caches/Homebrew/downloads/cee2bef6ac248d41bfa19eb8ef82dafb906efcd6a2bbc29d40425920013a89ae--b862de37f1e2cd7e7b561b723d01da9c8d248881.diff /private/tmp/futhark--patch-20200505-11593-1yz0nx5/b862de37f1e2cd7e7b561b723d01da9c8d248881.diff
Already downloaded: /Users/brew/Library/Caches/Homebrew/downloads/cee2bef6ac248d41bfa19eb8ef82dafb906efcd6a2bbc29d40425920013a89ae--b862de37f1e2cd7e7b561b723d01da9c8d248881.diff
==> Verifying cee2bef6ac248d41bfa19eb8ef82dafb906efcd6a2bbc29d40425920013a89ae--b862de37f1e2cd7e7b561b723d01da9c8d248881.diff checksum
==> Patching
==> Applying b862de37f1e2cd7e7b561b723d01da9c8d248881.diff
patch -g 0 -f -p1 -i /private/tmp/futhark--patch-20200505-11593-1yz0nx5/b862de37f1e2cd7e7b561b723d01da9c8d248881.diff
patching file src/Futhark/Pass/ExtractKernels/Interchange.hs
Hunk #1 FAILED at 102.
1 out of 1 hunk FAILED -- saving rejects to file src/Futhark/Pass/ExtractKernels/Interchange.hs.rej
Error: Failure while executing; `patch -g 0 -f -p1 -i /private/tmp/futhark--patch-20200505-11593-1yz0nx5/b862de37f1e2cd7e7b561b723d01da9c8d248881.diff` exited with 1.

[lukel97]

@bayandin looks like futhark was updated on master to a version that includes the patch. Hopefully this is it now

[bayandin]

Looks good now.
There're only audit complains

brew audit --skip-style cmt --online
brew audit --skip-style mighttpd2 --online

[lukel97]

@bayandin Yeah, and I think these are out of our control unfortunately (or at least, out of scope for ghc)

[SMillerDev]

Yeah, both are pre-existing issues. I say it's good to go!

[bayandin]

I'm merging it manually since it required to rearrange commits a bit.

Well done @bubba! Thanks a lot for your contribution 🎉

[bayandin]

It took about 5 hours just to upload all the bottles!
But everything is merged finally.

Thanks again @fishtreesugar, @bubba, and @Bo98!