Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tldr: update links for source #55357

Closed
wants to merge 2 commits into from
Closed

Conversation

owenvoke
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@sbrl
Copy link

sbrl commented May 27, 2020

This PR updates the tldr C client links to the new repository, as said repository was recently renamed.

@owenvoke
Copy link
Contributor Author

This appears to be failing due to the change to the SHA256 hash. I updated this as the package isn't building from source even with the currently live version.

brew install --build-from-source tldr

@sbrl
Copy link

sbrl commented May 27, 2020

For reference, both myself and @owenvoke are admins of the tldr-pages organisation on GitHub.

@SMillerDev
Copy link
Member

If it isn't currently building, was the version retagged? And if so, why?

@owenvoke
Copy link
Contributor Author

As far as I know, no. 🤔 The formula hash hasn't changed for years (3b3786d006), however it looks like the release in GitHub (https://github.com/tldr-pages/tldr-c-client/releases/tag/v1.3.0) was after that commit. So maybe? 🤔

Unfortunately I wasn't maintaining the project back then.

url "https://github.com/tldr-pages/tldr-cpp-client/archive/v1.3.0.tar.gz"
sha256 "6210ece3f5d8f8e55b404e2f6c84be50bfdde9f0d194a271bce751a3ed6141be"
url "https://github.com/tldr-pages/tldr-c-client/archive/v1.3.0.tar.gz"
sha256 "7e7f67f4c3cf7d448847e837df2122069b0cc8f7ed6963431e914b7929655efe"
revision 2

This comment was marked as outdated.

This comment was marked as duplicate.

@BrewTestBot
Copy link
Member

:shipit: @dawidd6 has triggered a merge.

@owenvoke owenvoke deleted the feature/tldr branch June 3, 2020 09:40
@owenvoke
Copy link
Contributor Author

owenvoke commented Jun 3, 2020

Thanks @dawidd6 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants