Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fwartner/mac-cleanup #55930

Closed
wants to merge 1 commit into from
Closed

Added fwartner/mac-cleanup #55930

wants to merge 1 commit into from

Conversation

fwartner
Copy link

@fwartner fwartner commented Jun 8, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

sha256 "52c454c9abac16801814a90d766ff1d7367a698b0e003bc3dfe02cdfde6d1fa6"

def install
chmod 0755, "cleanup.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

homepage "https://github.com/fwartner/mac-cleanup/"
url "https://github.com/fwartner/mac-cleanup/archive/1.0.2.tar.gz"
sha256 "52c454c9abac16801814a90d766ff1d7367a698b0e003bc3dfe02cdfde6d1fa6"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a depends_on :macos

end

test do
system "#{bin}/cleanup"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should check if the command had any effect.

@SMillerDev
Copy link
Member

Closing this as it's not carrying an open source license. See https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae

@SMillerDev SMillerDev closed this Jun 8, 2020
@HenrikBacher
Copy link

@SMillerDev project has been updated with the MIT License: https://github.com/fwartner/mac-cleanup/blob/master/LICENSE
Can this PR be re-opened?

@SMillerDev
Copy link
Member

It's better to just make a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants