Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be nice to install using brew #31

Closed
nitrocode opened this issue Dec 24, 2019 · 10 comments
Closed

Would be nice to install using brew #31

nitrocode opened this issue Dec 24, 2019 · 10 comments

Comments

@nitrocode
Copy link

Something like this would be more convenient

brew install cleanup
brew install mac-cleanup
@fwartner
Copy link
Collaborator

Well that´s a great idea!

@shin-sforzando
Copy link
Contributor

Has anyone started this issue?
I made a LGTM Formula, but it's the author's prerogative to push it to Homebrew.

class MacCleanup < Formula
  desc "Cleanup script for OSX"
  homepage "https://github.com/fwartner/mac-cleanup/"
  url "https://github.com/fwartner/mac-cleanup/archive/1.0.2.tar.gz"
  sha256 "52c454c9abac16801814a90d766ff1d7367a698b0e003bc3dfe02cdfde6d1fa6"

  def install
    chmod 0755, "cleanup.sh"
    bin.install "cleanup.sh" => "cleanup"
  end

  test do
    system "#{bin}/cleanup"
  end
end

Screen Shot 2020-06-07 at 1 45 56

I sincerely hope it's officially approved.

@nitrocode
Copy link
Author

Nice job! Actually the homebrew community discourages repo owners from submitting formula for their own projects.

if you put in a pr for the formula above, there's a good chance that they will accept it and we can all benefit.

@shin-sforzando
Copy link
Contributor

Nice job! Actually the homebrew community discourages repo owners from submitting formula for their own projects.

O, really? Where is it written?
As you can see, my formula is referring to this branch's release URL.
If @fwartner and core contributors doesn't do the same Release, it won't work. So I'd like to leave the PR to Homebrew to the author, if possible.

@fwartner
Copy link
Collaborator

fwartner commented Jun 8, 2020

Submitted the PR: #55930

Thank you for your support! :)

@shin-sforzando
Copy link
Contributor

My pleasure:)

@shin-sforzando
Copy link
Contributor

@fwartner Thank you for adding MIT License.
I'm rooting for you!

@nitrocode
Copy link
Author

O, really? Where is it written?
As you can see, my formula is referring to this branch's release URL.
If @fwartner and core contributors doesn't do the same Release, it won't work. So I'd like to leave the PR to Homebrew to the author, if possible.

I was referring to this

We frown on authors submitting their own work unless it is very popular.

From Acceptable-Formulae#niche-or-self-submitted-stuff but I suppose it meets the criteria of "very popular" due to the star count.

@piersolenski
Copy link

@fwartner Homebrew/homebrew-core#55930 (comment) would you mind opening a new PR? Would be awesome to get this on Homebrew!

@fwartner
Copy link
Collaborator

fwartner commented Dec 7, 2020

Done :)

@fwartner fwartner closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants