kibana 7.6.2 #55967
kibana 7.6.2 #55967
Conversation
|
Improved the test. What do you mean by the Python part? |
|
It currently depends on macOS due to a requirement for python 2. Could 7.x work with python 3? |
|
What's the best way to ensure it's not using system Python? I've tried adding a fake |
|
If you make it depend on |
|
Looks like it succeed, so hopefully that means it'll work outside of Mac. |
Formula/kibana.rb
Outdated
| s.gsub! "new Project(resolve(REPO_ROOT, 'x-pack/tsconfig.json')),", "" | ||
| s.gsub! "new Project(resolve(REPO_ROOT, 'x-pack/test/tsconfig.json'), 'x-pack/test'),", "" | ||
| end | ||
|
|
||
| inreplace "package.json", /"node": "10\.\d+\.\d+"/, %Q("node": "#{Formula["node@10"].version}") | ||
| system "yarn", "kbn", "bootstrap" | ||
| system "yarn", "build", "--oss", "--release", "--skip-os-packages", "--skip-archives" |
There was a problem hiding this comment.
We should probably directly call the build strict with
| system "yarn", "build", "--oss", "--release", "--skip-os-packages", "--skip-archives" | |
| system "node", "scripts/build", "--oss", "--release", "--skip-os-packages", "--skip-archives" |
here, because yarn build calls it with --all-platforms which is unnecessary for us.
| depends_on "node@10" | ||
|
|
||
| def install | ||
| # remove non open source files | ||
| rm_rf "x-pack" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Thanks @chrmoritz, looks like both the suggestions worked! |
|
Great! Can you confirm that everything works with the updated |
|
I'm not very familiar with the |
|
@chrmoritz is this ready to go? |
|
Kinda, if something isn't working correctly, which isn't covered by the isolated test, then people will open issues I guess. I'm also not someone with enough experience with the elastic stack to extensively test it completely. So fingers crossed, but I'm quite confident that it should work. Also it's still better than further keeping these formulae on the outdated 6.x release line. |
There was a problem hiding this comment.
Thanks @ankane ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉
|
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?For #55419
xpack is no longer included in
package.json(elastic/kibana#32722), but completely removing it fromprojects.tsis a bit more complicated now: https://github.com/elastic/kibana/blob/c14a620411be7e6e463520eafa61fa8d7efb84ce/src/dev/typescript/projects.ts#L29-L35Since we pass the
--ossflag tobuild, it seems like we shouldn't need to remove it.