-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecate date format #56903
Update deprecate date format #56903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one true date format!
This passes the syntax checks so should be good to merge and relieve the load on the CI queue. |
(and it also doesn't require new bottles) |
I was thinking that was the way to go but I was unsure. Thanks, Bo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?There was internal discussion about the varying date formats used for
deprecate! :date => "..."
. At present, there are two formats in use: "January 1, 2020" and "2020-01-01" (ISO-8601).There's a vocal contingent among us who are strongly in favor of ISO-8601 and believe there's value in this format over others, so this PR updates the existing deprecations accordingly.