Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecate date format #56903

Merged
merged 11 commits into from
Jun 25, 2020
Merged

Conversation

samford
Copy link
Member

@samford samford commented Jun 25, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

There was internal discussion about the varying date formats used for deprecate! :date => "...". At present, there are two formats in use: "January 1, 2020" and "2020-01-01" (ISO-8601).

There's a vocal contingent among us who are strongly in favor of ISO-8601 and believe there's value in this format over others, so this PR updates the existing deprecations accordingly.

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one true date format!

@Bo98
Copy link
Member

Bo98 commented Jun 25, 2020

This passes the syntax checks so should be good to merge and relieve the load on the CI queue.

@Bo98 Bo98 merged commit 5344bfc into Homebrew:master Jun 25, 2020
@Bo98
Copy link
Member

Bo98 commented Jun 25, 2020

(and it also doesn't require new bottles)

@samford
Copy link
Member Author

samford commented Jun 25, 2020

This passes the syntax checks so should be good to merge and relieve the load on the CI queue.

I was thinking that was the way to go but I was unsure. Thanks, Bo.

@samford samford deleted the update-deprecate-date-format branch June 25, 2020 21:39
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants