-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: enforce ISO-8601 in deprecation date #7835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Rylan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👍
Thanks! Once the formulae are merged into linuxbrew-core I'll rerun the CI and (assuming it's green) merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nitpick: ISO 8601
instead of ISO-8601
@Rylan12, the tests still use |
@reitermarkus Ahh, you're right. Looks like I jumped the gun a little on this one. Apologies for that. Can I commit these directly or should I still make a PR? |
Always create a PR so that CI can run on it before merging. |
Makes sense. I'll cc you on the PR. Thanks! |
Nice work @Rylan12! |
brew style
with your changes locally?brew tests
with your changes locally?Add RuboCop check to make sure
deprecate!
date is ISO-8601 compliantCorresponding homebrew-core PR: Homebrew/homebrew-core#56903