Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@*: fix post_install linkages and tweak caveats #57655

Closed

Conversation

lembacon
Copy link
Member

@lembacon lembacon commented Jul 8, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

python@3.7 is now versioned keg-only, while python@3.8 now becomes the default python3 and is being linked into the prefix. In post_install, linkages of pip3 and wheel3 should be updated. And caveats also need some minor tweaks.

Fixes #57651.

@@ -223,11 +224,6 @@ def post_install
(libexec/"bin").install_symlink (bin/versioned_name).realpath => unversioned_name
end

# post_install happens after link
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python@3.7 will no longer be linked into the prefix, so this should be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - I'll update my pull request to reflect this.


Unversioned symlinks `python`, `python-config`, `pip` etc. pointing to
`python3`, `python3-config`, `pip3` etc., respectively, have been installed into
#{opt_libexec}/bin

You can install Python packages with
pip3 install <package>
#{opt_bin}/pip3 install <package>
They will install into the site-package directory
#{HOMEBREW_PREFIX/"lib/python#{xy}/site-packages"}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still true.

@lembacon
Copy link
Member Author

lembacon commented Jul 8, 2020

Oops, a little bit slow. #57654

@lembacon lembacon closed this Jul 8, 2020
@lembacon lembacon deleted the python-post-install-linkages branch July 8, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading or installing Python latest version (3.8) does not override pip3 link
2 participants