Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@3.8: install pip3 and wheel3 to /usr/local/bin/ #57654

Closed
wants to merge 2 commits into from

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jul 8, 2020

Fixes #57651

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@iMichka
Copy link
Member

iMichka commented Jul 8, 2020

Thanks for the fix, I missed that part during the migration.

scpeters added a commit to gazebo-tooling/release-tools that referenced this pull request Jul 9, 2020
Provide direct path to pip3 in case it is not linked to
/usr/local/bin
Workaround until the following is merged:
Homebrew/homebrew-core#57654

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@MikeMcQuaid
Copy link
Member

Shouldn't block this PR but: a test do block to catch this would be handy.

@MikeMcQuaid
Copy link
Member

Hmm, wonder why system bin/"pip3", "list", "--format=columns" in the test didn't catch this...

@Bo98
Copy link
Member Author

Bo98 commented Jul 9, 2020

bin is /usr/local/Cellar/python@3.8/3.8.3_1/bin - not /usr/local/bin.

@MikeMcQuaid
Copy link
Member

Perhaps we could adjust the test to use HOMEBREW_PREFIX/bin?

@Bo98
Copy link
Member Author

Bo98 commented Jul 9, 2020

Possibly, but likely wouldn't have prevented the issue happening. It was intentionally missing from /usr/local/bin when python@3.8 was keg-only (and so such test couldn't have existed then) and it was just forgotten to add it when it was made non-keg-only.

@MikeMcQuaid
Copy link
Member

Thanks. Fine to leave as-is then 👍

scpeters added a commit to gazebo-tooling/release-tools that referenced this pull request Jul 9, 2020
Provide direct path to pip3 in case it is not linked to /usr/local/bin
Workaround until the following is merged:
Homebrew/homebrew-core#57654

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@Bo98 Bo98 closed this in 7cce21b Jul 9, 2020
@Bo98 Bo98 deleted the pip3 branch July 9, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading or installing Python latest version (3.8) does not override pip3 link
3 participants