-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update formulae with multiple licenses #58869
Conversation
Formula/mongoose.rb
Outdated
@@ -3,8 +3,7 @@ class Mongoose < Formula | |||
homepage "https://github.com/cesanta/mongoose" | |||
url "https://github.com/cesanta/mongoose/archive/6.17.tar.gz" | |||
sha256 "5bff3cc70bb2248cf87d06a3543f120f3b29b9368d25a7715443cb10612987cc" | |||
# license ["GPL-2.0", "Cesanta"] - pending https://github.com/Homebrew/brew/pull/7953 | |||
license "GPL-2.0" | |||
license ["GPL-2.0", "Cesanta"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casenta
isn't listed in the SPDX License List so I don't think we can allow it (it will fail brew audit
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my above comments, looks good ✅
Once a new release has been made, we just need to check to make sure there will be no major merge conflicts, and then we're good to go.
Formula/ffms2.rb
Outdated
@@ -6,7 +6,7 @@ class Ffms2 < Formula | |||
sha256 "b09b2aa2b1c6f87f94a0a0dd8284b3c791cbe77f0f3df57af99ddebcd15273ed" | |||
# The FFMS2 source is licensed under the MIT license, but its binaries | |||
# are licensed under the GPL because GPL components of FFmpeg are used. | |||
license "GPL-2.0" | |||
license ["MIT", "GPL-2.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way we've been using the multiple-license syntax is for when the user is given a choice for which license to use.
That's not the case here, because parts are under MIT
and parts are under GPL-2.0
. We should only specify the more restrictive license (which, I think, would be GPL-2.0
)
571a1cd
to
6f8c813
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
6f8c813
to
e688a8e
Compare
Adding diff --git a/Formula/fd.rb b/Formula/fd.rb
index 22e33ce2d5..20fc11a74d 100644
--- a/Formula/fd.rb
+++ b/Formula/fd.rb
@@ -3,7 +3,7 @@ class Fd < Formula
homepage "https://github.com/sharkdp/fd"
url "https://github.com/sharkdp/fd/archive/v8.1.1.tar.gz"
sha256 "7b327dc4c2090b34c7fb3e5ac7147f7bbe6266c2d44b182038d36f3b1d347cc1"
- license "Apache-2.0"
+ license ["Apache-2.0", "MIT"]
head "https://github.com/sharkdp/fd.git"
bottle do
|
|
@SeekingMeaning Maybe I'm wrong but I parsed it as |
Ah, I agree. Thank you for clarification |
There's a couple more that I don't see in this PR:
|
a13d905
to
c146172
Compare
I'm not sure how to license https://webkit.org/licensing-webkit/
Would this be |
This needs to updated to the new Homebrew/brew#8260 syntax |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?DNM: need to wait for next
brew
release