-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.15 #59486
go 1.15 #59486
Conversation
just a note in here, we will need an alias for |
First time looking at the checks for brew, forgive me if I am totally off, but the checks for this PR have been running for 10+ hours, is that expected ? |
Yes. As a rule, a version bump for any formula triggers a rebuild and retest for all build dependents. For |
Ah, got it. Thanks for the explain @gromgit. |
As usual, I would prefer to do it if it'll be not possible to upgrade all the formula to 1.15 |
Any way to see how many of the 500 have been successfully tested @gromgit ? |
Please also deprecate the appropriate old version. |
wow, that's a big difference, like is 1.15 slow or like more formulae or some other reason entirely ? |
10.14 results: There is a bunch a fails related to these change: https://golang.org/doc/go1.15#flag
Another bunch of fails looks similar and their error messages include
And different ones:
|
Addresses Homebrew#59486
Fixing this seems to be roadblocked by upstream: quic-go/quic-go#2614 |
Old build issues:
@bayandin, I think all the above covers your 10.14 list. |
Addresses Homebrew#59486
There are no extra fails on Catalina as well, let's give it another try |
Here're fresh results (from 10.13 and 10.14):
brew test --retry --verbose bettercap -- will be fixed by #59505
And this error still exists:
|
Final failures:
Switched to
I believe we're good to go 🎉 |
Could you put that in the go upgrade failure tracking issue as well? |
Agree, let's track the upgrade failures in a separate issue. Moving forward with a merge now! :) |
go 1.15 was shipped. thanks @bayandin for the efforts!! |
Created with
brew bump-formula-pr
.