Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnirehtet: update apk location #59767

Closed

Conversation

SalvatoreT
Copy link
Contributor

@SalvatoreT SalvatoreT commented Aug 17, 2020

There's now a way to specify the APK location that's supported by the
tool. Genymobile/gnirehtet#90

Closes Genymobile/gnirehtet#254

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@chenrui333 has a PR open that does a version bump (#59746), but this PR also removes the issue that @fxcoudert raised a while back (#46097 (comment)).

@SalvatoreT
Copy link
Contributor Author

SalvatoreT commented Aug 17, 2020

Now that @chenrui333's PR (#59746) has gone through, I rebased against master so this branch only has the change to remove the unnecessary wrapper script.

chenrui333
chenrui333 previously approved these changes Aug 17, 2020
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the update!!

@chenrui333 chenrui333 changed the title gnirehtet 2.5 gnirehtet: update apk location Aug 17, 2020
There's now a way to specify the APK location that's supported by the
tool. Genymobile/gnirehtet#90

Closes Genymobile/gnirehtet#254
@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Aug 17, 2020
@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@SalvatoreT SalvatoreT deleted the salvatoret/gnirehtet-2.5 branch August 17, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Homebrew to use custom APK path
3 participants