Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap 2.46 (new formula) #60283

Closed
wants to merge 1 commit into from
Closed

snap 2.46 (new formula) #60283

wants to merge 1 commit into from

Conversation

sergiusens
Copy link
Contributor

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@sergiusens sergiusens mentioned this pull request Aug 27, 2020
Closed
dawidd6
dawidd6 reviewed Aug 27, 2020
View reviewed changes
Formula/snap.rb Outdated Show resolved Hide resolved
dawidd6
dawidd6 reviewed Aug 27, 2020
View reviewed changes
Formula/snap.rb Outdated Show resolved Hide resolved
dawidd6
dawidd6 reviewed Aug 27, 2020
View reviewed changes
Formula/snap.rb Outdated Show resolved Hide resolved
dawidd6
dawidd6 reviewed Aug 27, 2020
View reviewed changes
Formula/snap.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Aug 27, 2020
bayandin
bayandin requested changes Aug 27, 2020
View reviewed changes
Formula/snap.rb Outdated Show resolved Hide resolved
Formula/snap.rb Outdated Show resolved Hide resolved
Formula/snap.rb Outdated Show resolved Hide resolved
@sergiusens
Copy link
Contributor Author

Thanks for the review @dawidd6, I believe I addressed your requests

@sergiusens
Copy link
Contributor Author

Thanks for the review @bayandin, I believe I addressed your requests as well.

SMillerDev
SMillerDev reviewed Aug 28, 2020
View reviewed changes
Formula/snap.rb Show resolved Hide resolved
Formula/snap.rb Outdated Show resolved Hide resolved
@sergiusens
Copy link
Contributor Author

db88e0e: I removed the option for --HEAD and added a specific "version" as the version was being incorrectly detected (2.46.vendor)

SMillerDev
SMillerDev reviewed Aug 31, 2020
View reviewed changes
Formula/snap.rb Outdated Show resolved Hide resolved
@sergiusens
snap 2.46 (new formula)
ed6010b 
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@sergiusens sergiusens deleted the snap branch September 2, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonymouse64 anonymouse64 anonymouse64 left review comments

@dawidd6 dawidd6 dawidd6 left review comments

@bayandin bayandin bayandin requested changes

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sergiusens @BrewTestBot @bayandin @SMillerDev @anonymouse64 @dawidd6