-
-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.15.1 #60495
go 1.15.1 #60495
Conversation
d525833
to
9fea580
Compare
Out of curiosity, is there anything blocking this PR? Go 1.15.1 is a security fix for golang/go#40928. For more information: https://www.redteam-pentesting.de/en/advisories/rt-sa-2020-004/-inconsistent-behavior-of-gos-cgi-and-fastcgi-transport-may-lead-to-cross-site-scripting |
The failing formula are, they need to be checked and fixed. |
Okay, it looks like a dependency issue with the charm recipe. If nobody beats me to it, I will dig into it later.
|
Every Go update breaks some upstream formula. Perhaps we shouldn’t block security updates on broken or abandoned dependent formula? |
previous failure list with go1.15 Final failures:
|
@ydnar that is true, but let's minimize the impact and the disruption. (I am going to see what I can do really quick) |
@chenrui333 anyway to record which failures aren’t regressions? Maybe mark which tests are known failures, so they can be ignored if they fail in subsequent builds (or re-fail if they pass)? |
yeah, the merge decision is usually ad-hoc as well, so knowing the previous failures is actually pretty trivial. |
Aye. It's more the time. The smoke tests take long enough, and then there's the inevitable back and forth discussion while Go dev moves forward. 1.15.2 is almost ready. My opinion: Ad-hoc process shouldn't block security updates. For major/minor updates, sure. |
Alright, let's merge this security fix, I will follow up with the regression testing failures. Appreciate your idea in here. |
record the upgrade failure in here |
Created with
brew bump-formula-pr
.