Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd (new formula) #74219

Merged
merged 1 commit into from Apr 10, 2021
Merged

systemd (new formula) #74219

merged 1 commit into from Apr 10, 2021

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Mar 30, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@iMichka iMichka added the linux to homebrew-core Migration of linuxbrew-core to homebrew-core label Mar 30, 2021
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 30, 2021
@danielnachun
Copy link
Member

This needs

on_linux do
    ENV.prepend_path "PERL5LIB", "#{Formula["intltool"].libexec}/lib/perl5"
end

for intltool to work on Linux. In a different formulae I installed XML::Parser as a resource separately, but it seems it is sufficient to just add the Perl directory from intltool to the PERL5LIB for it to find the necessary module.

@iMichka
Copy link
Member Author

iMichka commented Mar 31, 2021

Needs #74241

@iMichka
Copy link
Member Author

iMichka commented Mar 31, 2021

Needs #71854

MikeMcQuaid
MikeMcQuaid previously approved these changes Mar 31, 2021
Formula/systemd.rb Outdated Show resolved Hide resolved
@dawidd6
Copy link
Member

dawidd6 commented Apr 7, 2021

==> brew audit systemd --online --new-formula
==> FAILED
==> Installing 'bundler' gem
systemd:
  * Dependency 'libxslt' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.
  * Dependency 'm4' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.
  * Dependency 'expat' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.
Error: 3 problems in 1 formula detected

So this audit should be skipped if depends_on :linux I guess.

Well since it's an audit for new formulae... let's just ignore it.

@iMichka
Copy link
Member Author

iMichka commented Apr 10, 2021

Let's merge this. The failure is unrelated, we added the virtuoso formula that depends on net-tools, but we did not add the net-tools formula, which messes up the test here. I'll fix this by adding the missing formula: #74906

@iMichka iMichka merged commit 1574623 into Homebrew:master Apr 10, 2021
@iMichka iMichka deleted the systemd branch April 10, 2021 08:28
@iMichka iMichka mentioned this pull request Apr 10, 2021
5 tasks
@carlocab
Copy link
Member

The better way to do this might've been to cherry-pick your commit from #74906 and add it here (or vice-versa), so we can be more confident that nothing's broken before merging.

@iMichka
Copy link
Member Author

iMichka commented Apr 10, 2021

Actually the even better way would have been to fix virtuoso first and remove the broken dependency from there. Let's merge the net-tools formula as soon as possible and everything will go back to normal.

@github-actions github-actions bot added the outdated PR was locked due to age label May 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request linux to homebrew-core Migration of linuxbrew-core to homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants