dub v1.1.1 #7470
Closed
dub v1.1.1 #7470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
requested changes
Dec 2, 2016
| end | ||
|
|
||
| depends_on "pkg-config" => :build | ||
| depends_on "pkg-config" => :recommended |
There was a problem hiding this comment.
depends_on "pkg-config" => [:recommended, :build] but I do wonder the benefits of making this optional?
There was a problem hiding this comment.
dub uses it at runtime if it can find it, but is also perfectly happy without. It's no longer used for building dub itself unless you're building it with an old compiler. I've updated it to depends_on "pkg-config" => [:recommended, :run]
MikeMcQuaid
approved these changes
Dec 2, 2016
|
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! For future reference the preferred commit message format is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Doesn't pass. Can someone explain? I read about it https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md#specifying-other-formulae-as-dependencies so I assumed it would be ok to use.auditbecause it doesn't like recommended dependencies for some reason