Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 16.0.0 #75595

Closed
wants to merge 1 commit into from
Closed

node 16.0.0 #75595

wants to merge 1 commit into from

Conversation

branchvincent
Copy link
Member

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 20, 2021
carlocab
carlocab requested changes Apr 20, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update npm to 7.10.0.

See https://github.com/nodejs/node/releases/tag/v16.0.0, nodejs/node#38254

@derrabus derrabus mentioned this pull request Apr 20, 2021
Closed
5 tasks
@carlocab carlocab mentioned this pull request Apr 20, 2021
Merged
5 tasks
@carlocab
Copy link
Member

There are three failures: bcoin, cash-cli, and jhipster. bcoin and cash-cli look unrelated. (e.g. #75622)

jhipster looks like it could be fixed by depending on node@15 instead (c/o #75598). However, if there's an upstream patch we can use to get jhipster to work with this version of Node we should probably use that.

@carlocab carlocab mentioned this pull request Apr 21, 2021
Closed
5 tasks
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Apr 21, 2021
@carlocab
jhipster: depend on node@14
6e71236 
It doesn't work with Node 16 yet.

See Homebrew#75595.
@chrmoritz
Copy link
Contributor 

Error: Module did not self-register: '/usr/local/Cellar/bcoin/2.1.2_2/libexec/lib/node_modules/bcoin/node_modules/bcrypto/build/Release/bcrypto.node'.

bcoin just needs a revision bump, because of the native addon I think.

BrewTestBot pushed a commit that referenced this pull request Apr 21, 2021
@carlocab @BrewTestBot
jhipster: depend on node@14
c65e21f 
It doesn't work with Node 16 yet.

See #75595.

Closes #75637.

Signed-off-by: Nanda H Krishna <me@nandahkrishna.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@carlocab carlocab mentioned this pull request Apr 21, 2021
Closed
5 tasks
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Apr 21, 2021
@carlocab
bcoin: switch to node@14
01db866 
This may be compatible with Node 16. However, it seems less wasteful of
CI resources to switch this to Node 14 first and back to Node 16 later,
rather than re-run Homebrew#75595 with a revision bump to `bcoin`.
@carlocab
Copy link
Member

carlocab commented Apr 21, 2021 •
edited

cash-cli is definitely just broken (#75705). jhipster fixed in #75637. Switched bcoin to node@14 in #75704, so this can be merged as soon as #75704 is.

Or we can try giving bcoin revision bump here, but that sounds a little speculative to me at the moment.

Edit: Looks like the test output of cash-cli changed with no changes to the formula: #75709

BrewTestBot pushed a commit that referenced this pull request Apr 21, 2021
@carlocab @BrewTestBot
bcoin: switch to node@14
1ba36cb 
This may be compatible with Node 16. However, it seems less wasteful of
CI resources to switch this to Node 14 first and back to Node 16 later,
rather than re-run #75595 with a revision bump to `bcoin`.

Closes #75704.

Signed-off-by: Michka Popoff <3406519+iMichka@users.noreply.github.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab
Copy link
Member

Thanks @branchvincent!

@branchvincent branchvincent deleted the bump-node-16.0.0 branch April 21, 2021 22:20
@carlocab
Copy link
Member

@chrmoritz: you were right about bcoin: #75714 thanks for the hint!

@github-actions github-actions bot added the outdated PR was locked due to age label May 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@branchvincent @carlocab @chrmoritz @BrewTestBot