cash-cli: Fix test

[n-thumann]

Fixes failing test in e.g. #75705.
The error is caused by the default API that cash-cli uses and now always requires an API key. Unfortunately, there's no other way for testing than using a dumb version check, but (according to the Formula Cookbook) this is better than nothing and definitely better than a failing test.

---

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

[carlocab]

So the error is expected then? If so, we can keep the existing test, and just modify it to account for exit code and output from failure.

[carlocab]

Thanks for this, @n-thumann. We can do better than a version test here, now that we know that the failure is expected.

[n-thumann]

I wouldn't say that the error is expected. It seems like 20 days ago exchangeratesapi.io suddenly starts requiring an API key and the author of cash-cli hasn't handles that yet. I'm not sure if this will be fixed soon as the last commit on master in 17 months old :/

[carlocab]

I wouldn't say that the error is expected. It seems like 20 days ago exchangeratesapi.io suddenly starts requiring an API key and the author of cash-cli hasn't handles that yet. I'm not sure if this will be fixed soon as the last commit on master in 17 months old :/

I see. In that case, we definitely shouldn't change the test. Otherwise we have no way of knowing whether this problem ever gets fixed or not.

[n-thumann]

Looks like there are some issues matching against the output

==> /usr/local/Cellar/cash-cli/4.2.1/bin/cash 100 USD PLN CHF
- Converting...
✖ Something went wrong :(

Error: cash-cli: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /Something\ went\ wrong\ :\(/ to match "\n".

[carlocab]

My opinion hasn't really changed from what I said above: #75709 (comment)

That the test fails when you try it seems to be the correct result, as it appears that this software is broken right now.

[carlocab]

@SMillerDev thoughts here? Do we want to change the test?

[SMillerDev]

I think it should be deprecated as unmaintained and the test adjusted with a comment that they are no longer fully accurate.

[carlocab]

Works for me. @n-thumann, do you mind making those changes here?

[n-thumann]

Sure, give me a sec :)

[carlocab]

Thanks, @n-thumann.