nvc 1.5.1

[chenrui333]

Created with brew bump-formula-pr.

resource blocks may require updates.

[carlocab]

I think we can switch this from llvm@11 to llvm. Don't forget the llvm@11 reference in the install method.

[carlocab]

Nope, failed to build. Upstream CI uses the llvm formula though.

Maybe we also need the --enable-vhpi flag?

[nandahkrishna]

Still fails, checked locally as well.

[carlocab]

Very weird. Can we try running autogen unconditionally? We'll need to move the deps out of the head block though.

[nandahkrishna]

That results in the same error 😅:

==> ./autogen.sh
==> ./tools/fetch-ieee.sh
==> ./configure --with-llvm=/usr/local/opt/llvm/bin/llvm-config --prefix=/usr/local/Cellar/nvc/1.5.1 --with-system-cc=/usr/bin/clang --enable-vhpi
==> make
Last 15 lines from /Users/<username>/Library/Logs/Homebrew/nvc/04.make:
  AR       lib/libfst.a
  CXXLD    bin/nvc
Undefined symbols for architecture x86_64:
  "_LLVMInitializeX86AsmPrinter", referenced from:
      _cgen in libcgen.a(lib_libcgen_a-cgen.o)
  "_LLVMInitializeX86Target", referenced from:
      _cgen in libcgen.a(lib_libcgen_a-cgen.o)
  "_LLVMInitializeX86TargetInfo", referenced from:
      _cgen in libcgen.a(lib_libcgen_a-cgen.o)
  "_LLVMInitializeX86TargetMC", referenced from:
      _cgen in libcgen.a(lib_libcgen_a-cgen.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [bin/nvc] Error 1
make: *** [all] Error 2

[nandahkrishna]

The --HEAD build works fine and passes all tests. I think nickg/nvc@251e18d is required.

[carlocab]

I've gotten the tarball to build with llvm 12. Issue may not be that. Just poking at it some more.

[carlocab]

Tried building outside of brew. Encountered the same error as in this PR. Then, I tried applying the change at #76646 (just do ln -s $(brew --prefix llvm)/lib/libLLVM.dylib $(brew --prefix llvm)/lib/libLLVM-12.dylib). This allows me to build successfully outside of brew.

When I try to build with brew using a patched llvm as in #76646, the build fails, except with a different error, which shows up later in the build:

  NVC      lib/ieee/IEEE.STD_LOGIC_MISC
ld: file too small (length=0) file '/private/tmp/nvc-20210514-18670-17vg8it/nvc-1.5.1/lib/nvc/_NVC.ENV-body.o' for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
** Fatal: /usr/bin/clang failed with status 1
make[1]: *** [lib/nvc/NVC.ENV] Error 1

Seems related to this step

homebrew-core/Formula/nvc.rb

Line 34 in e1bbe44

system "./tools/fetch-ieee.sh"

as I didn't run it when I tried building outside of brew.

[carlocab]

Oops, no it's not. Looks like the step I highlighted above doesn't do anything:

❯ ./tools/fetch-ieee.sh
The IEEE standard library sources are now included in the repository for
convenience. They can also be download from the IEEE SA:

  https://standards.ieee.org/content/dam/ieee-standards/standards/web/download/

Note that the license forbids the distribution of modifications.

[carlocab]

I don't really understand why deparallelizing the build helps here. I've tried several times now to build outside of brew with make -j4 and I can't reproduce the build failure.

[carlocab]

Let's try a parallel build here. Maybe my computer just sucks.

[nandahkrishna]

Works now 🎉, this should be good to merge?

[BrewTestBot]

🤖 A scheduled task has triggered a merge.