amfora 1.8.0 (new formula)

[vladimyr]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

[nandahkrishna]

Should this be GPL-3.0-only? I find no mentions of "or later" in non-template text (see search query).

[chenrui333]

here is the debian copyright file reference, https://metadata.ftp-master.debian.org/changelogs//main/a/amfora/amfora_1.8.0-1_copyright

[chenrui333]

I think we can go with GPL-3.0-or-later, here is the arch side ref:

[carlocab]

Debian doesn't indicate -or-later, though, and I'm inclined to trust them here. It seems to actually be

license all_of: [
  "GPL-3.0-only",
  any_of: ["GPL-3.0-only", "MIT"],
]

...or, equivalently:

license any_of: [
  "GPL-3.0-only",
  all_of: ["GPL-3.0-only", "MIT"],
]

[vladimyr]

Only rr code (amfora's subpackage) is dual-licensed under GPL3 (only?, inherits amfora's license) or MIT. According to this, I think we should stick with GPL-3.0-only? 🤔

[nandahkrishna]

We can specify with comments which licenses apply to which directories/files, like in e2fsprogs.

[vladimyr]

We can specify with comments which licenses apply to which directories/files, like in e2fsprogs.

Interesting, thanks for the pointer! 👍

[carlocab]

Only rr code (amfora's subpackage) is dual-licensed under GPL3 (only?, inherits amfora's license) or MIT. According to this, I think we should stick with GPL-3.0-only? 🤔

This is exactly why you can either license it under GPLv3 entirely or both MIT (rr subpackage) and GPLv3 (everything else).

[vladimyr]

I've just changed it to:

license all_of: [
  "GPL-3.0-only",
  any_of: ["GPL-3.0-only", "MIT"], # rr
]

That should be correct, right?

[chenrui333]

we should definitely have some license hell emoji :D

[nandahkrishna]

LGTM, thanks @vladimyr!

[BrewTestBot]

@nandahkrishna has triggered a merge.