babel 7.14.8 #81582
Closed
babel 7.14.8 #81582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
bump-formula-pr
|
Looks like the same failure as in #81556. Could be fixed in Homebrew/brew#11750 see; |
carlocab
added
the
CI-no-fail-fast
|
I think |
|
@carlocab I'm new to the world of homebrew-core, is that something we do manually, or is there an automatic way to resolve resource blocks? |
|
They're mostly done automatically for resources from PyPI, but everything else needs to be done manually, sadly. |
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Jul 21, 2021
The LLVM formulae build universal binaries for compiler-rt. This is why these formulae use `ENV.permit_arch_flags`. Infer vendors its own clang, and so also has its own compiler-rt. `babel` and `contentful-cli` both install the npm package `fsevents`, which installs a universal native module `fsevents.node`. I suggest adding them to the allowlist for now so we have a list that keeps track of them. (It would be nice if JSON files allowed comments though.) I have changes in mind for `brew` that will allow us to easily extract the native slices from these binaries, but I'd like to see it needed by more formulae before we add it to `brew`. This list should help us keep track of the number of formulae that would need this. This commit unblocks Homebrew#81556 and Homebrew#81582. See Homebrew/brew#11737 for context.
6 tasks
|
If #81591 is merged as-is you can rebase this to fix the audit error. |
cho-m
added
the
CI-force-linux
carlocab
added a commit
to carlocab/brew
that referenced
this pull request
Jul 21, 2021
`FormulaInstaller` calls `audit_installed` at install time, which invokes methods in `FormulaCellarChecks`. One of these methods makes a call to `tap_audit_exception` (cf. Homebrew#11750), but this method isn't visible in `FormulaInstaller`. Instead of trying to replicate the logic of `tap_audit_exception` in `FormulaAuditor` (or trying to initialise an instance of one to make the call to `FormulaAuditor`'s implementation of it), let's just implement a stub that assumes an exception always exists. I'll need to think a bit about whether this is the right fix for this, but currently the missing method error is blocking PRs in Homebrew/core, so let's go with this for now. [1] [1] e.g. Homebrew/homebrew-core#81388, Homebrew/homebrew-core#81582
7 tasks
|
Oops. That new CI error is my fault. Fixed in Homebrew/brew#11755. |
|
Different kind of failure though -- #81591 removes an audit failure that we could choose to ignore. Homebrew/brew#11755 fixes an install failure that we can't ignore. |
carlocab
added a commit
that referenced
this pull request
Jul 21, 2021
The LLVM formulae build universal binaries for compiler-rt. This is why these formulae use `ENV.permit_arch_flags`. Infer vendors its own clang, and so also has its own compiler-rt. `babel` and `contentful-cli` both install the npm package `fsevents`, which installs a universal native module `fsevents.node`. I suggest adding them to the allowlist for now so we have a list that keeps track of them. (It would be nice if JSON files allowed comments though.) I have changes in mind for `brew` that will allow us to easily extract the native slices from these binaries, but I'd like to see it needed by more formulae before we add it to `brew`. This list should help us keep track of the number of formulae that would need this. This commit unblocks #81556 and #81582. See Homebrew/brew#11737 for context.
carlocab
force-pushed
the
bump-babel-7.14.8
branch
from
ef81d25
to
62db996
Compare
|
Thanks @carlocab 🥳 |
carlocab
approved these changes
Jul 21, 2021
|
🤖 A scheduled task has triggered a merge. |
|
Huh, bottles are all the same. Looks like this installs macOS native modules on Linux too. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-pr.resourceblocks may require updates.