audit_exceptions: add universal_binary_allowlist
#81591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LLVM formulae build universal binaries for compiler-rt. This is why these formulae use `ENV.permit_arch_flags`. Infer vendors its own clang, and so also has its own compiler-rt. `babel` and `contentful-cli` both install the npm package `fsevents`, which installs a universal native module `fsevents.node`. I suggest adding them to the allowlist for now so we have a list that keeps track of them. (It would be nice if JSON files allowed comments though.) I have changes in mind for `brew` that will allow us to easily extract the native slices from these binaries, but I'd like to see it needed by more formulae before we add it to `brew`. This list should help us keep track of the number of formulae that would need this. This commit unblocks Homebrew#81556 and Homebrew#81582. See Homebrew/brew#11737 for context.
carlocab
added
the
CI-syntax-only
BrewTestBot
added
the
automerge-skip
SMillerDev
approved these changes
Jul 21, 2021
MikeMcQuaid
approved these changes
Jul 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?The LLVM formulae build universal binaries for compiler-rt. This is why
these formulae use
ENV.permit_arch_flags. Infer vendors its own clang,and so also has its own compiler-rt.
babelandcontentful-cliboth install the npm packagefsevents,which installs a universal native module
fsevents.node. I suggestadding them to the allowlist for now so we have a list that keeps track
of them. (It would be nice if JSON files allowed comments though.)
I have changes in mind for
brewthat will allow us to easily extractthe native slices from these binaries, but I'd like to see it needed by
more formulae before we add it to
brew. This list should help us keeptrack of the number of formulae that would need this.
This commit unblocks #81556 and #81582.
See Homebrew/brew#11737 for context.